Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small issues #57

Closed
ShimmyShaman opened this issue Mar 14, 2022 · 2 comments
Closed

Small issues #57

ShimmyShaman opened this issue Mar 14, 2022 · 2 comments

Comments

@ShimmyShaman
Copy link
Collaborator

The requirements for the library have increased with recent commits and implementations of the callback model. I've had to install gcc version 7.5 and add the following to my projects CMakeLists file (c++11 is no longer sufficient).
add_compile_options(-std=c++14)
I'm not quite sure what of that is worth mentioning (if at all) in the README.

also... CallbackTypeSelctor is a typo mistake in latest commit
@pjueon
Copy link
Owner

pjueon commented Mar 15, 2022

Thank you for the report.

I'm not quite sure what of that is worth mentioning (if at all) in the README.

Yeah, I think the C++ standard requirements should be mentioned in README.
Honestly I thought it was already mentioned in README. I'll fix it soon.

also... CallbackTypeSelctor is a typo mistake in latest commit

Oh, I didn't noticed it haha. I'll fix it too. Thanks.

@pjueon
Copy link
Owner

pjueon commented Mar 15, 2022 •
edited
Loading

Ok, I just pushed the fix for this issue.

  • Now it can be compiled with C++11
  • Add the C++ standard requirements in the README file

@pjueon pjueon closed this as completed Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ShimmyShaman @pjueon