Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast module bug with 'prefix' option in "dynamic_names.yml" #244

Open
ShadowOne333 opened this issue Jun 7, 2021 · 0 comments
Open

Cast module bug with 'prefix' option in "dynamic_names.yml" #244

ShadowOne333 opened this issue Jun 7, 2021 · 0 comments

Comments

@ShadowOne333
Copy link
Contributor

ShadowOne333 commented Jun 7, 2021

Editing the "dynamic_names.yml" to use the "prefix" option under "mode" has two bugs in-game.

  • Bug No. 1 - Paula's name doesn't appear

Using the following setup in "Cast/dynamic_names.yml" makes it so that the game doesn't print the name of "Paula" during the credits.

Paula's dad:
  mode: prefix
  text: "Pap[C0] de "
Paula's mom:
  mode: prefix
  text: "Mam[C0] de "

EBSpanish001

According to @PhoenixBound, this could be fixed adding a to_block_size or something else of text.len() in the following line:

rom.write_multi(self.custom_asm_offset + 26, len(self.text), 2)


  • Bug No. 2 - Both Paula's mom and Paula's dad entries use the "mom" text for both entries

Modifying the file inside "Font/character_substitutions.yml" and adding 'á': '[C0]' into it to make use of the accented letter "a" creates a workaround for Bug No. 1, but there's still another issue when using this method.
Upon compiling the source, the game only reads the entry for "Paula's mom" and prints it for both instances of mom and dad.

Paula's dad:
  mode: prefix
  text: "Papá de "
Paula's mom:
  mode: prefix
  text: "Mamá de "

EBSpanish000

I tried several combinations, changing only the mom entry, or only the dad entry, and it always results in the Mom entry being duplicated.


For reference, I've been using this code in previous versions of CoilSnake for my Spanish translation, in which it worked just fine:
https://github.com/ShadowOne333/EarthBound-Spanish-Translation/blob/master/ccscript/asm_credits.ccs
(And this for the compressed graphics before the Cast module):
https://github.com/ShadowOne333/EarthBound-Spanish-Translation/blob/master/ccscript/asm_compressed_graphics.ccs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant