Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

termios package does not compile under OpenBSD, NetBSD or DragonflyBSD #25

Closed
driusan opened this issue Dec 8, 2016 · 3 comments
Closed

Comments

@driusan
Copy link

driusan commented Dec 8, 2016

The termios/pty_bsd.go build tags build the file for FreeBSD, NetBSD and OpenBSD, but two of the syscall constants that it refers to (syscall.SYS_POSIX_OPENPT and syscall.TIOCGPTN) are only defined for FreeBSD if you grep the syscall package source.

In addition to this, the BSD variant files are missing build tags for DragonflyBSD.

@mndrix
Copy link
Contributor

mndrix commented Apr 25, 2018

I think I've fixed this in pull request #30. I know it works on OpenBSD. If anyone has access to FreeBSD, DragonFly BSD and NetBSD, I'd appreciate any testing you could do there.

@iquiw
Copy link

iquiw commented Apr 29, 2018

I tested it with go version go1.10.1 netbsd/386 on NetBSD 8.0_RC1 and go version go1.10.1 netbsd/amd64 on NetBSD current (8.99.14).
Both go build and go test succeeded.

@gdamore
Copy link
Contributor

gdamore commented Jun 25, 2019

I think this issue should be closed. Builds for those platforms seem to work for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants