pkgdev commit fails if not new ebuilds staged (fails with MissingManifest)

[thesamesam]

Every week, I bump sys-devel/gcc to the latest round of GCC snapshots (for the 10, 11, 12, and sometimes 13 branches) unkeyworded.

I usually bump (copy) all the ebuilds locally, run pkgdev manifest (so it downloads all of them), then start to build them one-by-one if no ebuild changes were needed. I usually try to test 10 first, commit, then 11, then commit, then ...

Recently, this happens:

$ pkgdev commit
 * generating manifest: sys-devel/gcc::gentoo
sys-devel/gcc
  RedundantVersion: version 10.3.0-r2: slot(10) keywords are overshadowed by version: 10.3.1_p20211126
  StableRequest: version 10.4.0: slot(10) no change in 41 days for unstable keywords: [ ~amd64, ~arm, ~arm64, ~hppa, ~ppc, ~ppc64, ~sparc, ~x86 ]
  IndirectInherits: version 11.2.0: toolchain-funcs: indirect inherit usage: 'tc-is-cross-compiler', line 20
  RedundantVersion: version 11.2.0: slot(11) keywords are overshadowed by version: 11.3.0
  RedundantVersion: version 11.2.1_p20220115: slot(11) keywords are overshadowed by version: 11.3.0
  MissingManifest: version 11.3.1_p20220812: distfile missing from Manifest: [ gcc-11-20220812.tar.xz ]
  StableRequest: version 12.1.0: slot(12) no change in 82 days for unstable keywords: [  ]
  DroppedKeywords: version 13.0.0_pre20220807: alpha, amd64, arm, arm64, hppa, ia64, m68k, mips, ppc, ppc64, riscv, s390, sparc, x86

FAILURES
sys-devel/gcc
  MissingManifest: version 11.3.1_p20220812: distfile missing from Manifest: [ gcc-11-20220812.tar.xz ]

Steps to reproduce:

1. git checkout 0259106bb65e70b66aef0f43da3e0a3b7534e3f7~1 (before I added this week's bumps)
2. cp gcc-10.4.1_p{20220804,20220811}.ebuild gcc-11.3.1_p{20220805,20220812}.ebuild gcc-12.1.1_p{20220806,20220812}.ebuild
3. pkgdev manifest
4. git add gcc-10.4.1_p20220811.ebuild && pkgdev commit
5. Hit failure with MissingManifest for e.g. GCC 11 (which is unstaged).

$ pkgdev --version
pkgdev 0.2.1-4-g98cfd69 -- Tue, 9 Aug 2022 21:59:07 +0100
$ pkgcheck --version
pkgcheck 0.10.13-15-g7b96afb -- Thu, 11 Aug 2022 22:35:27 +0300
$ git --version
git version 2.37.2

$ cat ~/.config/pkgdev/pkgdev.conf
[DEFAULT]
commit.scan = true
commit.signoff = true
push.ask = true
showkw.format = simple

[gentoo]
commit.signoff = true

pkgdev commit didn't always have this issue, so I think this might be related to #65 or #74. I am not using --if-modified though.

[arthurzam]

Do note that the facilities around manifesting with only staged ebuilds isn't the best. I will try to find a solution, but doing multiple bumps at a start and committing one by one is very fragile as you noticed.

[thesamesam]

Understood. It's a shame because it worked before and radhermit implemented the functionality (040a9ad) after I'd asked for it :(

The main motivation is paying the distfile fetching cost up front.

The original bug to add it was #33.

There's actually a suggestion re stash in there too for pkgdev to possibly use.

[arthurzam]

@thesamesam could you check if using pkgcore/pkgcore#371 helps now and it works for you (it did for me)?

[thesamesam]

Thanks Arthur, I'll test it shortly as there's a new batch of GCCs