Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SVG for non-animated icons #364

Closed
amondit opened this issue Apr 15, 2024 · 4 comments
Closed

Use SVG for non-animated icons #364

amondit opened this issue Apr 15, 2024 · 4 comments

Comments

@amondit
Copy link
Contributor

amondit commented Apr 15, 2024

Is your feature request related to a problem? Please describe.
I'm using card-mod to resize the icon and text sizes of this cards, but when I use animated: false (to avoid the high-cpu-usage bug when using animated svgs), the icons do look blurry (due to the fact that png icons are then used and not properly resized).

Describe the solution you'd like
There are already icons in the svg-static folders, could we use those when animated is set to false? Or add another configuration flag (force-svg?) if for some compatibility reasons we want to keep having PNGs when not animated.

Describe alternatives you've considered
I'm using animated: true so that I have good resized looking icons on my dashboard, but this causes high cpu usages on my low power tablets (so heat and unnecessary power usage). I also tried to recompile the card to force-use the svg-static icon folders, it worked but then I loose automatic updates from hacs.

Thanks a lot for considering this request!

@amondit
Copy link
Contributor Author

amondit commented Apr 19, 2024

I created a PR for it, let me know what you think.

Thanks!

@pkissling
Copy link
Owner

hi @amondit. thank you for the PR. i am currently on vacation. i will have a look in 10 days.

@amondit
Copy link
Contributor Author

amondit commented Apr 19, 2024

No rush, enjoy your vacations! :)

@pkissling
Copy link
Owner

merged and release #366

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants