Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge changes to output gathering #33

Merged
merged 9 commits into from
Sep 30, 2015
Merged

Merge changes to output gathering #33

merged 9 commits into from
Sep 30, 2015

Conversation

pkittenis
Copy link
Member

Pull request for output branch that resolves #32.

TODO before merge:

  • Public API change in get_output function, needs documenting.
  • Tests for getting partially failed host list output with all raised exceptions as failures
  • Possibly a new public function for getting output from multiple commands now that get_output is for a single command.

@pkittenis
WIP for #32 - Added test for getting partial host list output in the …
d6fb4a2 
…case where the host lists contains one or more failing hosts. Refactored run_command to allow raising an exception on errors or not
@pkittenis
Updated get_output and exec_command for changed behaviour. Added host…
b8b423a 
… as argument to exceptions so that output can be updated correctly for the host the exception occured for. Updated test_pssh_client_run_command_get_output_explicit for changed get_output interface - Resolves #32
@pkittenis
Use single quotes when running bash command to avoid variable substit…
9cb344b 
…ution errors. Fixes #34
@pkittenis
WIP for #32 - Added test for getting partial host list output in the …
30631c0 
…case where the host lists contains one or more failing hosts. Refactored run_command to allow raising an exception on errors or not
@pkittenis
Updated get_output and exec_command for changed behaviour. Added host…
00af978 
… as argument to exceptions so that output can be updated correctly for the host the exception occured for. Updated test_pssh_client_run_command_get_output_explicit for changed get_output interface - Resolves #32
@pkittenis
Use single quotes when running bash command to avoid variable substit…
2f6c8ab 
…ution errors. Fixes #34
@pkittenis pkittenis added this to the Release 0.80 milestone Sep 25, 2015
@pkittenis pkittenis merged commit cd59fab into master Sep 30, 2015
@pkittenis pkittenis deleted the output branch October 2, 2015 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 0.80
Development

Successfully merging this pull request may close these issues.

Allow output gathering for working hosts when one or more hosts have failures
1 participant
@pkittenis