Animating Protocol is Package-Protected

[cody1024d]

I was trying to implement a custom view (very similar to the one used by default, but at a bigger size, and some margins on the title label), however, the animation protocol is currently not public, and so I cannot implement it with my custom view. Would you be open to a pull request to fix this?

It seems like, without the above, custom views would not work nearly as well.

@objc protocol PKHUDAnimating {

    func startAnimation()
    optional func stopAnimation()
}

[cody1024d]

On that note, the actual animation static class also does not expose the discrete rotation animation as public, either. This would be nice for custom views which are only different in small ways when compared to the provided progress view.

public final class PKHUDAnimation {

    static let discreteRotation: CAAnimation = {
...
...

[PGLongo]

Hi @cody1024d sorry for the delay. Are you still interested in this feature?

[cody1024d]

I definitely would. I am still open to making a PR for it too, it would be relatively quick! (Considering I just have to change the scoping on a few of these properties). I would have time to do it in the coming days, if that's something you'd be ok with?

[PGLongo]

For me is ok. But consider to make differents PR to keep everything simple. First of take care of this issue and the problem of the protocol, after that we could discuss on how to proceed to allow changing the size and other stuff of the HUD.

[cody1024d]

Good idea. I will make separate PRs, so each change can be discussed on it's own merit. I should have some time today to do them, but no promises! :)

[PGLongo]

Later I will create an issue where we can discuss about the resize.

[cody1024d]

@PGLongo Just made a PR with the protocol changes :)

[PGLongo]

Merged

[tommylo]

Still can not import PKHUDAnimating protocol

Use of undeclared type "PKHUDAnimating"