Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast Path impl does not escape special chars like $ #220

Closed
boozook opened this issue Aug 7, 2023 · 1 comment
Closed

Fast Path impl does not escape special chars like $ #220

boozook opened this issue Aug 7, 2023 · 1 comment
Labels
bug Something isn't working invalid This doesn't seem right

Comments

@boozook
Copy link

boozook commented Aug 7, 2023

OS: macOS
Shell: ZSH (default)

I have $ in filenames in some local wiki. Seems to it's "tiddlywiki".

fclones produces commands like this:

rm '/Users/ak/Documents/GD Wiki/Notes/tiddlers/$__plugins_tiddlywiki_help_HelpPanel_Videos.md'

But instead must be:

rm "/Users/ak/Documents/GD Wiki/Notes/tiddlers/\$__plugins_tiddlywiki_help_HelpPanel_Videos.md"
  1. with escaped $
  2. with normal quotes " because single quotes ' is for eval.
@boozook boozook changed the title Fast Path impl do not escapes special chars like $ Fast Path impl does not escapes special chars like $ Aug 7, 2023
@pkolaczk pkolaczk added the bug Something isn't working label Sep 5, 2023
@pkolaczk pkolaczk changed the title Fast Path impl does not escapes special chars like $ Fast Path impl does not escape special chars like $ Oct 18, 2023
@pkolaczk
Copy link
Owner

Just tried it on macOS and zsh quoting works the same way how fclones assumes it to work:

piotr@mbp fclones (update-deps) % zsh
piotr@mbp fclones (update-deps) % echo '$foo'
$foo
piotr@mbp fclones (update-deps) % echo "$foo"

piotr@mbp fclones (update-deps) % 

Single quotes are for literal quoting (no eval), doule quotes do eval.

@pkolaczk pkolaczk added the invalid This doesn't seem right label Oct 20, 2023
@pkolaczk pkolaczk closed this as not planned Won't fix, can't repro, duplicate, stale Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants