Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MongoDB driver dependency #187

Closed
ctrlsam opened this issue Dec 7, 2021 · 2 comments · Fixed by #203
Closed

Update MongoDB driver dependency #187

ctrlsam opened this issue Dec 7, 2021 · 2 comments · Fixed by #203
Labels
area/core Refers to Mongo Seeding library 💥 breaking Breaking change 🚀 enhancement New feature or request
Milestone

Comments

@ctrlsam
Copy link

ctrlsam commented Dec 7, 2021

The closeConnection function needs to be reworked to check if the db is connected, without using the deprecated method isConnected

(node:169094) DeprecationWarning: isConnected is deprecated and will be removed in the next major version
    at Database.<anonymous> (/home/user/Programming/some_project/node_services/node_modules/mongo-seeding/src/database/database.ts:105:38)
    at Generator.next (<anonymous>)
    at /home/user/Programming/some_project/node_services/node_modules/mongo-seeding/dist/database/database.js:8:71
    at new Promise (<anonymous>)
    at Object.<anonymous>.__awaiter (/home/user/Programming/some_project/node_services/node_modules/mongo-seeding/dist/database/database.js:4:12)
    at Database.closeConnection (/home/user/Programming/some_project/node_services/node_modules/mongo-seeding/dist/database/database.js:94:16)
    at Seeder.<anonymous> (/home/user/Programming/some_project/node_services/node_modules/mongo-seeding/src/index.ts:144:24)
    at Generator.next (<anonymous>)
    at fulfilled (/home/user/Programming/some_project/node_services/node_modules/mongo-seeding/dist/index.js:15:58)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
@pkosiec
Copy link
Owner

pkosiec commented Dec 12, 2021

Hi @ctrlsam, thank you for reporting this.

I will rename this issue to "Update MongoDB driver dependency" and try to address that in Mongo Seeding 4. Cheers!

@pkosiec pkosiec changed the title DeprecationWarning: isConnected is deprecated and will be removed in the next major version Update MongoDB driver dependency Dec 12, 2021
@pkosiec pkosiec added 🚀 enhancement New feature or request area/core Refers to Mongo Seeding library labels Dec 12, 2021
@pkosiec pkosiec added this to the 4.0.0 milestone Sep 28, 2022
@pkosiec
Copy link
Owner

pkosiec commented Feb 3, 2023

Finally resolved in #203 🥳

@pkosiec pkosiec closed this as completed Feb 3, 2023
@pkosiec pkosiec added the 💥 breaking Breaking change label Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core Refers to Mongo Seeding library 💥 breaking Breaking change 🚀 enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants