Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation fails on Linux kernels >= 4.12 #19

Closed
marcelhuberfoo opened this issue Aug 3, 2017 · 2 comments
Closed

Compilation fails on Linux kernels >= 4.12 #19

marcelhuberfoo opened this issue Aug 3, 2017 · 2 comments
Assignees
Labels

Comments

@marcelhuberfoo
Copy link
Contributor

Due to kernel changes/cleanup, compilation of the rapiddisk kernel module fails with the following output:

/rapiddisk-dkms/usr/src/rapiddisk-5.0 $ make -C $(pwd) M=$PWD
make: Entering directory '/rapiddisk-dkms/usr/src/rapiddisk-5.0'
make -C/lib/modules/4.12.3-1-ARCH/build M=/rapiddisk-dkms/usr/src/rapiddisk-5.0
make[1]: Entering directory '/usr/lib/modules/4.12.3-1-ARCH/build'
  LD      /rapiddisk-dkms/usr/src/rapiddisk-5.0/built-in.o
  CC [M]  /rapiddisk-dkms/usr/src/rapiddisk-5.0/rapiddisk.o
/rapiddisk-dkms/usr/src/rapiddisk-5.0/rapiddisk.c: In function ‘attach_device’:
/rapiddisk-dkms/usr/src/rapiddisk-5.0/rapiddisk.c:708:26: error: ‘struct queue_limits’ has no member named ‘discard_zeroes_data’
  rdsk->rdsk_queue->limits.discard_zeroes_data = 1;
                          ^
make[2]: *** [scripts/Makefile.build:309: /rapiddisk-dkms/usr/src/rapiddisk-5.0/rapiddisk.o] Error 1
make[1]: *** [Makefile:1512: _module_/rapiddisk-dkms/usr/src/rapiddisk-5.0] Error 2
make[1]: Leaving directory '/usr/lib/modules/4.12.3-1-ARCH/build'
make: *** [Makefile:32: all] Error 2
make: Leaving directory '/rapiddisk-dkms/usr/src/rapiddisk-5.0'

According to this mailing list entry the flag can completely be removed.

@pkoutoupis
Copy link
Owner

@marcelhuberfoo,
Please see my notes on your pull request.

@pkoutoupis
Copy link
Owner

Addressed with commit: 354c759

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants