Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

role IDs for default email templates #2724

Closed
bozana opened this issue Aug 19, 2017 · 7 comments
Closed

role IDs for default email templates #2724

bozana opened this issue Aug 19, 2017 · 7 comments
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.

Comments

@bozana
Copy link
Collaborator

bozana commented Aug 19, 2017

The role IDs in emailTemplates.xml and DB table email_templates_default should be adapted/migrated... It seems like they are not used?

@bozana bozana changed the title role IDs in emailTemplates.xml role IDs for default emailTemplates Aug 19, 2017
@bozana bozana changed the title role IDs for default emailTemplates role IDs for default email templates Aug 19, 2017
@asmecher
Copy link
Member

@bozana, just FYI, those were purely informational -- they were used to show who the sender and recipients were in the Prepared Emails list.

@mpbraendle
Copy link
Contributor

mpbraendle commented Nov 27, 2017

Hmm. As you see in the screenshot on #2906, for most of the default templates, Sender and Receiver are set as "Subscription Manager", which is plain wrong. Neither sender nor receiver can be changed, or when a new template is added, configured.
For an editorial team to set this up this might be disturbing. Either remove those columns (if not used anymore), or add an option to edit them.

@pnault
Copy link
Contributor

pnault commented Dec 6, 2017

Hi,
I'm totally with @mpbraendle on this: absence of information is better then wrong information. In 3.0.1 not all column were filled but those who were had wright information, see: https://forum.pkp.sfu.ca/t/prepared-emails-sender-recipient-has-subscription-manager/35967?u=pnault

@NateWr NateWr added the Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days. label Mar 27, 2018
@NateWr NateWr moved this from To do to Needs Specification in Email: notifications, templates, drafting, sending Mar 27, 2018
@tothbog
Copy link

tothbog commented Jul 4, 2018

We use the latest version, 3.1.1.2, but we have the same problem. We cannot change sender, nor who is "signing" the letter. For instance, if an editor invite a new referee, the REVIEWER_REGISTER template is sent by the editor, but at the end of the letter the principal contact name appears. I tried to change it to ${editorialContactName} without success. Also, I cannot put a Dear "NAME" to the beginning, but I don't see why.

Is there any solution to these?

@asmecher
Copy link
Member

asmecher commented Jul 4, 2018

@tothbog, I don't think that's related to this issue, which specifically deals with the numeric role_ids for display in the email listing. I'd suggest posting your question on our support forum (http://forum.pkp.sfu.ca/).

@tothbog
Copy link

tothbog commented Jul 5, 2018

Ok, sorry, I did not realize that. Thanks, I will post there.

@NateWr NateWr added Bug:1:Low A bug that does not have a severe consequence or affects a small number of users. and removed Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days. labels Oct 25, 2018
@NateWr
Copy link
Member

NateWr commented May 27, 2019

This has been fixed as part of #2906.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Projects
No open projects
Development

No branches or pull requests

6 participants