You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The adjustment should be made for all themes using this code, including default, bootstrap3, healthSciences; already applied the fix to the latter, although it can be not full.
Tagging @NateWr
The text was updated successfully, but these errors were encountered:
So I've flagged up the issue in the Bootstrap3 theme (we'll have other adjustments to make to fit the Smarty v3 syntax). Otherwise we should be good to go.
Nice find here @Vitaliy-1. I'll close the OJS PR but let me know if you think I'm wrong.
Pagination doesn't work as expected because
$prevUrl
and$nextUrl
are always not empty due to whitespaces. For example, it can be tracked in this line: https://github.com/pkp/healthSciences/blob/master/templates/frontend/components/pagination.tpl#L20Think, the easiest way is just to trim these variables on assigning: pkp/ojs#1942
Although, there can be more variables that should be treated like this.
The adjustment should be made for all themes using this code, including default, bootstrap3, healthSciences; already applied the fix to the latter, although it can be not full.
Tagging @NateWr
The text was updated successfully, but these errors were encountered: