Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review/remove broken notifications code #4270

Closed
asmecher opened this issue Nov 29, 2018 · 2 comments
Closed

Review/remove broken notifications code #4270

asmecher opened this issue Nov 29, 2018 · 2 comments
Assignees
Milestone

Comments

@asmecher
Copy link
Member

It appears that the notification system used to support notifications with user_id=0, which IIRC used to apply to anyone active on the submission. These notifications do not appear to work anymore (see e.g. NOTIFICATION_TYPE_EDITOR_ASSIGNMENT_... constants).

Some investigation is needed to determine when/why they stopped working, and from there, whether it's worth fixing them -- or whether the whole infrastructure should be torn out. (This would be a good opportunity to reduce complexity and remove that code, since my sense is that it's not badly missed.)

@NateWr
Copy link
Member

NateWr commented Aug 29, 2022

@asmecher want to keep this one open?

@asmecher
Copy link
Member Author

No, I'll close this, thanks.

@asmecher asmecher closed this as not planned Won't fix, can't repro, duplicate, stale Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants