Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise unsubscribe options in user profile notifications form #8431

Open
Vitaliy-1 opened this issue Nov 15, 2022 · 1 comment
Open

Revise unsubscribe options in user profile notifications form #8431

Vitaliy-1 opened this issue Nov 15, 2022 · 1 comment
Assignees
Labels
Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.
Milestone

Comments

@Vitaliy-1
Copy link
Collaborator

Describe the problem
In user profile -> notifications, there are options to enable/disable certain notification types, which are no longer shown to the end user.
screencapture-localhost-8000-index-php-publicknowledge-user-profile-2022-11-15-20_08_01
There are 3 notification levels, from which only the NOTIFICATION_LEVEL_TASK is displayed in the user's taskbar. Some are shown in banners on certain submission workflow stages, e.g.:

Notification::NOTIFICATION_LEVEL_NORMAL => [
but most of the notifications with unsubscribe option aren't displayed anywhere in the system and are used to be sent with an email. This means that there is no need for the existing of the 2 options - enable notification and unsubscribe from email, in particular, for:

  • A new announcement has been created (NOTIFICATION_TYPE_NEW_ANNOUNCEMENT)
  • An issue has been published (NOTIFICATION_TYPE_PUBLISHED_ISSUE)
  • A new article, "Title," has been submitted (NOTIFICATION_TYPE_SUBMISSION_SUBMITTED)
  • Weekly email of outstanding tasks (NOTIFICATION_TYPE_EDITORIAL_REMINDER)
  • Statistics report summary (NOTIFICATION_TYPE_EDITORIAL_REPORT)

To Reproduce
Steps to reproduce the behavior:

  1. Go to Announcements and create a new one
  2. Publish it with the option to send a notification to all registered user
  3. Log in as a user, who is subscribed to see new announcement notifications
  4. See that this notification isn't displayed anywhere in the interface, only email is sent

What application are you using?
OJS main branch

@Vitaliy-1 Vitaliy-1 added the Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day. label Nov 15, 2022
@Vitaliy-1 Vitaliy-1 added this to the 3.5 milestone Nov 15, 2022
@NateWr
Copy link
Member

NateWr commented Nov 16, 2022

I'd prefer to solve this alongside a complete rewrite of the unsubscribe settings. In my opinion, the existing approach to "tasks" needs to be rethought, inline with the recommendations for an activity feed in #5729. There is no need to allow the user to unsubscribe from in-app notifications -- only emails. So the whole UI and the underlying data structure could be simplified to focus on email subscriptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.
Projects
Status: Backlog
Development

No branches or pull requests

3 participants