Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client.requestOptions() should be documented #107

Open
eahutchins opened this issue Apr 7, 2014 · 3 comments
Open

client.requestOptions() should be documented #107

eahutchins opened this issue Apr 7, 2014 · 3 comments

Comments

@eahutchins
Copy link

The README.md should document the requestOptions() API (why does it take two args, for example?) Maybe show an example enabling github's preview API:

client.requestOptions({
   headers: {
      Accept: 'application/vnd.github.she-hulk-preview+json'
   }
});
@pksunkara
Copy link
Owner

requestOptions() is used by octonode internally. It is not much helpful to the end users.

@eahutchins
Copy link
Author

Is there a better way to enable github preview APIs? Mucking with requestDefaults[] directly seems worse...

@pksunkara
Copy link
Owner

No, you can not modify individual api call request options. At least for now. I am planning to refactor octonode with alpaca

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants