Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename *Filter matchers to *Matcher #91

Closed
GlenDC opened this issue Mar 15, 2024 · 1 comment
Closed

rename *Filter matchers to *Matcher #91

GlenDC opened this issue Mar 15, 2024 · 1 comment
Labels
easy An easy issue to pick up for anyone. good first issue Good for newcomers mentor available A mentor is available to help you through the issue.
Milestone
v0.2

Comments

@GlenDC
Copy link
Member

GlenDC commented Mar 15, 2024

Naming is ideally consistent. At some point I started using filter as a synonym for matcher. This is however a potential source of confusion. As such we should rename them to *Matcher as the trait is Matcher as well
@GlenDC GlenDC added good first issue Good for newcomers easy An easy issue to pick up for anyone. labels Mar 15, 2024
@GlenDC GlenDC added this to the v0.2 milestone Mar 15, 2024
@GlenDC GlenDC added the mentor available A mentor is available to help you through the issue. label Mar 15, 2024
This was referenced Mar 21, 2024
Closed
Merged
@GlenDC
Copy link
Member Author

GlenDC commented Mar 21, 2024

Closed in #115 by @rabuu .

@GlenDC GlenDC closed this as completed Mar 21, 2024
@GlenDC GlenDC assigned GlenDC and unassigned GlenDC Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy An easy issue to pick up for anyone. good first issue Good for newcomers mentor available A mentor is available to help you through the issue.
Projects
None yet
Milestone
v0.2
Development

No branches or pull requests
1 participant
@GlenDC