Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to click entry header link twice #1372

Closed
mxdanger opened this issue May 19, 2022 · 4 comments
Closed

Unable to click entry header link twice #1372

mxdanger opened this issue May 19, 2022 · 4 comments
Labels
bug Something is broken or not working as expected

Comments

@mxdanger
Copy link
Member

mxdanger commented May 19, 2022

If you click the header of an entry, where the link icon is, the entry is added to the url with the ID and timeline position, as expected.

However, if you click the same entry header again it does not update. A side effect of this is that if you have the entry already linked to in the url and you change the timeline position it's not possible to update it if you click the entry header.

@mxdanger mxdanger added the bug Something is broken or not working as expected label May 19, 2022
Hans5958 added a commit to Hans5958/place-atlas that referenced this issue Jul 3, 2022
Hans5958 added a commit to Hans5958/place-atlas that referenced this issue Jul 3, 2022
Hans5958 added a commit to Hans5958/place-atlas that referenced this issue Jul 4, 2022
@AnonymousRandomPerson
Copy link
Contributor

I'm not sure I understand the root issue here. Is the timeline position supposed to be added to the URL? I only see the ID added.

@mxdanger
Copy link
Member Author

mxdanger commented Aug 1, 2022

Yes, the issue is that the timeline position should be added to the URL.

@AnonymousRandomPerson
Copy link
Contributor

Oh, that's different from what the ticket implies.

"...the entry is added to the url with the ID and timeline position, as expected."
This uses the present tense, implying that the timeline is already added to the URL. And wouldn't this be an enhancement rather than a bug?

@Hans5958
Copy link
Member

It's been a while since the change and I think the issue is gone (as in, you can click the entry header twice and more), so I can close it.

As of what to do when an entry does not exist in a certain period (discussed on #1384, iirc), this can be created as another issue, since it is worth discussing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken or not working as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants