Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Ground overlays #98

Merged
merged 10 commits into from
Oct 31, 2022
Merged

[WIP] Ground overlays #98

merged 10 commits into from
Oct 31, 2022

Conversation

tmcw
Copy link
Collaborator

@tmcw tmcw commented Oct 27, 2022

Work-in-progress!

Support for ground overlays. This may not land, it's still an experiment.

Concrete TODOs:

  • Support groundoverlays in the "folders" mode
  • Documentation (update readme, add to jsdoc)
  • Support rotation
  • Differentiate ground overlays from other types
  • Writeup examples of how to actually integrate this with Leaflet & Mapbox GL / Maplibre

Published as a prerelease - @tmcw/togeojson@3.1.0-0


Less-concrete TODOs:

  • Should ground overlays even be features? In the current code, an overlay becomes a polygon with an icon href property. This is a little weird! Implementations will, most likely, pick these overlays out and display them in a totally different manner than features. Showing an overlay as a box is probably not intended. On the other hand, if they aren't features then they'll not be included in the featurecollection returned by kml(), and will lead to more format fracturing and invention.

@tmcw tmcw force-pushed the ground-overlays branch 4 times, most recently from 75aad22 to 39ab6a9 Compare October 27, 2022 21:06
@tmcw tmcw merged commit 43d357d into main Oct 31, 2022
@tmcw tmcw deleted the ground-overlays branch October 31, 2022 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant