Make Plack::Util::header_* less undertested #498
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not finished with this branch – there are lots of tests still missing. But I am posting this as an RFC.
Do you agree with the split into separate test files?
Is the added build-time dependency on Test::Differences OK with you?
Its
eq_or_diff
produces much nicer output on test failure thanis_deeply
does. The downside is that it adds four more transitive dependencies. Fortunately they are all pure-Perl, at least.If you don’t want it, I can just
s/eq_or_diff/is_deeply/g
it out – they are signature-compatible with each other. That means compromise is also possible, i.e. attempting to load Test::Differences and then using eithereq_or_diff
oris_deeply
depending on whether it’s available.What is your preference?