Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Plack::Util::header_* less undertested #498

Merged
merged 2 commits into from Feb 9, 2015
Merged

Make Plack::Util::header_* less undertested #498

merged 2 commits into from Feb 9, 2015

Conversation

ap
Copy link
Contributor

@ap ap commented Feb 9, 2015

I am not finished with this branch – there are lots of tests still missing. But I am posting this as an RFC.

  1. Do you agree with the split into separate test files?

  2. Is the added build-time dependency on Test::Differences OK with you?

    Its eq_or_diff produces much nicer output on test failure than is_deeply does. The downside is that it adds four more transitive dependencies. Fortunately they are all pure-Perl, at least.

    If you don’t want it, I can just s/eq_or_diff/is_deeply/g it out – they are signature-compatible with each other. That means compromise is also possible, i.e. attempting to load Test::Differences and then using either eq_or_diff or is_deeply depending on whether it’s available.

    What is your preference?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.84% when pulling 6dbe592 on ap:header-utils-tests into db4148f on plack:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.84% when pulling 6dbe592 on ap:header-utils-tests into db4148f on plack:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 81.88% when pulling 6dbe592 on ap:header-utils-tests into db4148f on plack:master.

@miyagawa
Copy link
Member

miyagawa commented Feb 9, 2015

Let's not add Test::Difference - nice output would be only nice when the
test fails :)

miyagawa added a commit that referenced this pull request Feb 9, 2015
Make Plack::Util::header_* less undertested
@miyagawa miyagawa merged commit 7d6898c into plack:master Feb 9, 2015
@ap ap deleted the header-utils-tests branch February 9, 2015 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants