Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undeclared dependency on File::Basename #582

Open
andk opened this issue Nov 5, 2016 · 4 comments
Open

Undeclared dependency on File::Basename #582

andk opened this issue Nov 5, 2016 · 4 comments

Comments

@andk
Copy link

andk commented Nov 5, 2016

As per subject. Grep:

http://search.cpan.org/grep?release=Plack-1.0042;string=File::Basename;n=1;C=0

Sample fail report:

http://www.cpantesters.org/cpan/report/73715836

HTH&&Thanks

@haarg
Copy link
Member

haarg commented Nov 5, 2016

File::Basename has been in core since 5.0

@andk
Copy link
Author

andk commented Nov 5, 2016

On Fri, 04 Nov 2016 19:26:10 -0700, Graham Knop notifications@github.com said:

File::Basename has been in core since 5.0

Yeah, maybe the perl is a vendor perl without it? I don't know why it
has no File::Basename. Maybe somebody uninstalled it?

I see dependency declarations as something that should not assume
anything about the target system, just declare what needs to be
available. In any case it can't hurt to have what seems like a redundant
declaration because if anything changes in what you may assume about the
target system, the declaration will try to defend the build.

andreas

@haarg
Copy link
Member

haarg commented Nov 5, 2016

I don't have any issue with listing it as a prereq, but it seems unlikely to fix that test report. File::Basename is core only, so it can never be fulfilled through CPAN.

@andk
Copy link
Author

andk commented Nov 6, 2016

On Sat, 05 Nov 2016 12:43:03 -0700, Graham Knop notifications@github.com said:

I don't have any issue with listing it as a prereq, but it seems
unlikely to fix that test report. File::Basename is core only, so it
can never be fulfilled through CPAN.

Oh, this coreonlyness is what I wasn't aware of. In this case I agree with you.

andreas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants