Refix the thumbnail url problem with Storage so that it throws an err…

…or when no filename is passed.
plainblack · Feb 17, 2010 · 25274c5 · 25274c5
1 parent 7db6470
commit 25274c5
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/lib/WebGUI/Storage.pm b/lib/WebGUI/Storage.pm
@@ -1246,13 +1246,13 @@ The file to retrieve the thumbnail for.
 sub getThumbnailUrl {
     my $self     = shift;
     my $filename = shift;
-    if (! $self->isImage($filename)) {
-        return '';
-    }
 	if (! defined $filename) {
 		$self->session->errorHandler->error("Can't find a thumbnail url without a filename.");
 		return '';
 	}
+    if (! $self->isImage($filename)) {
+        return '';
+    }
     my $thumbname = 'thumb-' . $filename;
     if (! -e $self->getPath($thumbname)) {
         $self->session->errorHandler->error("Can't find a thumbnail for a file named '$filename' that is not in my storage location.");