Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copying server config to bungee before bungeecord installation causes server name to be wrong in the database #1678

Closed
AuroraLS3 opened this issue Dec 30, 2020 · 2 comments
Labels
Bug Issues that contain unintended behavior note: Misconfiguration server: Networks Issues related to Network functionality Technical Debt
Milestone

Comments

@AuroraLS3
Copy link
Collaborator

Describe the issue

If the following line is in the config (ServerName), the server identification will pick up the name from the config instead of using "BungeeCord", making Plan not detect it as a proxy server.

Server:
    ServerName: Plan

Additional information

Due to technical debt Plan detects bungeecord instances from name "BungeeCord" in the database. Due to recent changes to server identification the config name can be used instead, as it was assumed the field is not present in the proxy config.

That field can however be added if the original config is from a server and bungeecord config defaults are copied on top of it.

@AuroraLS3 AuroraLS3 added Bug Issues that contain unintended behavior server: Networks Issues related to Network functionality Technical Debt note: Misconfiguration labels Dec 30, 2020
@AuroraLS3 AuroraLS3 added this to Done in Backlog (Bugs) Jan 1, 2021
@AuroraLS3 AuroraLS3 added this to the 5.2 milestone Jan 19, 2021
@ItTakesTwo
Copy link

FYI: this also breaks the multi server functionality in combination with a proxy.
As long as Server.ServerName is present in the config file, the Network.Name value will not be picked up and /plan network only returns Server is not connected to a network. The link redirects to server page.
Additionally the web interface always redirects to the server page from the server running the Plan webserver and does not show any network information.

@AuroraLS3
Copy link
Collaborator Author

This has been fixed in the latest version by replacing the proxy detection with platform based instead of name based check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues that contain unintended behavior note: Misconfiguration server: Networks Issues related to Network functionality Technical Debt
Projects
No open projects
Development

No branches or pull requests

2 participants