Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing messages breaks the receive log #50

Closed
boreq opened this issue Sep 9, 2022 · 1 comment · Fixed by #194
Closed

Removing messages breaks the receive log #50

boreq opened this issue Sep 9, 2022 · 1 comment · Fixed by #194
Assignees
@boreq
Labels
bug Something isn't working priority/high
Milestone
Use scuttlego in ...

Comments

@boreq
Copy link
Contributor

boreq commented Sep 9, 2022

If a message was removed then we just have to skip that message in the receive log. For now I didn't touch the receive log as it is unclear what that new contract will look like. Maybe we should also communicate message removals to Swift somehow. Or we just need to redesign that integration completely.
@boreq boreq added this to the Needed by Planetary milestone Sep 9, 2022
@boreq
Copy link
Contributor Author

boreq commented Sep 9, 2022

Related to #20, #16, #39 etc.

@boreq boreq self-assigned this Dec 19, 2022
@boreq boreq removed this from the Use scuttlego in Planetary milestone Jan 13, 2023
@boreq boreq added this to the Use scuttlego in Planetary milestone Feb 14, 2023
@boreq boreq mentioned this issue Feb 14, 2023
Merged
@boreq boreq added bug Something isn't working priority/high labels Feb 14, 2023
@boreq boreq changed the title Removing messages may break the receive log Removing messages breaks the receive log Feb 14, 2023
@boreq boreq linked a pull request Feb 14, 2023 that will close this issue
Delted messages are removed from receive log #194
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boreq boreq

Labels
bug Something isn't working priority/high
Projects
Verse: Nos Projects
Archived in project
Milestone
Use scuttlego in Planetary
Development

Successfully merging a pull request may close this issue.

Delted messages are removed from receive log planetary-social/scuttlego
1 participant
@boreq