Modify current dropdown to more flexible #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macsleven
suggested changes
Apr 8, 2021
macsleven
suggested changes
May 17, 2021
macsleven
suggested changes
May 18, 2021
There was a problem hiding this comment.
- The dropdown menu should dismiss when you tap outside it.
- Implement same dropdown menu for watch only wallet(without the privacy menu in the list.)
- Use the appropriate font for the list.
- There should be the new label beside the privacy label when privacy is not setup.
macsleven
suggested changes
May 20, 2021
implement dropdown to wallet page add Localizable string for Privacy
add dropdown to watch wallet menu
JustinBeBoy
force-pushed
the
modify_dropdown
branch
from
0331337
to
fbb1eeb
Compare
macsleven
suggested changes
May 30, 2021
it's exactly Lightgrey |
|
make the grey a lighter shade, the current gray is too dark, maybe a similar gray to a disabled button |
|
The dropdown covers the balance when open, it should be like in the screenshot below |
JustinBeBoy
force-pushed
the
modify_dropdown
branch
from
e97138e
to
ce45302
Compare
macsleven
suggested changes
May 31, 2021
macsleven
approved these changes
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR custom the dropdown with feature:
Screenshot:
