implement account filter operation on privacy setup #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
while sending to self, I can still see my mixed account in the receiving account dialog. I think this happens if your balance in the mixed account is greater than zero
|
dreacot
previously approved these changes
May 23, 2021
beansgum
suggested changes
May 24, 2021
There was a problem hiding this comment.
- When I tap
send to self, it changes the From accountmixedtodefault, this is probably happening becausedefaultis the first account on my list but it should not change becausemixedis valid for sending to self. - When sending to self, I'm allowed to send from an unmixed account to my second wallet's account. The second wallet is technically "send to others" so tapping an account from another wallet should set the
Fromaccount to allow only mixed.
|
Accounts from my second wallet are not visible when sending to address and the wallet does not have privacy enabled.
|
dreacot
approved these changes
May 28, 2021
beansgum
approved these changes
May 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the appropriate account to display on the send view for both privacy wallet and non privacy wallet.
closes Display appropriate unmixed and mixed account #758