add different notification messages for vote transactions #766
Conversation
I don't get what you mean? |
| var amount: String { | ||
| switch tx!.type { | ||
| case DcrlibwalletTxTypeVote: | ||
| return String(format: LocalizedStrings.voteReward, tx!.voteReward) |
There was a problem hiding this comment.
tx!.voteReward is in int64, convert it to a decimal number.
There was a problem hiding this comment.
What's not necessary? Display the vote reward in the notification or converting the vote reward to a decimal number?
There was a problem hiding this comment.
@JustinBeBoy what's not necessary?
There was a problem hiding this comment.
sorry I mean "tx!.voteReward is in int64, convert it to a decimal number." not necessary
There was a problem hiding this comment.
Why is it not necessary to display the amount in float64 instead of int64? @JustinBeBoy
| case DcrlibwalletTxTypeRevocation: | ||
| return "" | ||
| default: | ||
| return "\(LocalizedStrings.youReceived) \(tx!.dcrAmount.round(8).description) DCR" |
There was a problem hiding this comment.
Put this entire sentence in localizable strings.
"youReceived" = "You received %@ DCR";
| var amount: String { | ||
| switch tx!.type { | ||
| case DcrlibwalletTxTypeVote: | ||
| return String(format: LocalizedStrings.voteReward, tx!.voteReward) |
localize entire receive notification text
dreacot
force-pushed
the
vote_transactions
branch
from
781e903
to
952e0f1
Compare
| var amount: String { | ||
| switch tx!.type { | ||
| case DcrlibwalletTxTypeVote: | ||
| return String(format: LocalizedStrings.voteReward, tx!.voteReward.toDecimal) |
There was a problem hiding this comment.
This doesn't convert the value from atoms to dcr.
| return String(format: LocalizedStrings.voteReward, tx!.voteReward.toDecimal) | |
| return String(format: LocalizedStrings.voteReward, tx!.dcrVoteReward.round(8).description) |
| @@ -9,6 +9,12 @@ | |||
| import UIKit | |||
| import Dcrlibwallet | |||
|
|
|||
| extension Int64 { | |||
beansgum
dismissed stale reviews from JustinBeBoy and macsleven
it's not necessary.
Resolves #731
This PR adds notification messages for the various Vote Transactions