Safe check appdelegate wallet operations #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
macsleven
commented
Jun 1, 2021
•
macsleven
commented
- This PR safe checks wallet operations when app is not fully active.
- optimized wallet sync operations and not allowing the os screen sleep while wallet is syncing,mixing or rescanning.
JustinBeBoy
suggested changes
Jun 3, 2021
| @@ -716,19 +717,22 @@ extension OverviewViewController: DcrlibwalletSyncProgressListenerProtocol { | |||
| func onSyncCanceled(_ willRestart: Bool) { | |||
| DispatchQueue.main.async { | |||
| self.updateUI(syncCompletedSuccessfully: false) | |||
| UIApplication.shared.isIdleTimerDisabled = false | |||
There was a problem hiding this comment.
We have many different synchronous processes, so we have to check them all to complete to set UIApplication.shared.isIdleTimerDisabled = false
| } | ||
| } | ||
|
|
||
| func onSyncCompleted() { | ||
| DispatchQueue.main.async { | ||
| self.updateUI(syncCompletedSuccessfully: true) | ||
| self.setMixerStatus() | ||
| UIApplication.shared.isIdleTimerDisabled = false |
| } | ||
| } | ||
|
|
||
| func onSyncEndedWithError(_ err: Error?) { | ||
| DispatchQueue.main.async { | ||
| self.updateUI(syncCompletedSuccessfully: false) | ||
| UIApplication.shared.isIdleTimerDisabled = false |
| @@ -821,6 +826,7 @@ extension OverviewViewController: DcrlibwalletBlocksRescanProgressListenerProtoc | |||
|
|
|||
| func onBlocksRescanEnded(_ walletID: Int, err: Error?) { | |||
| DispatchQueue.main.async { | |||
| UIApplication.shared.isIdleTimerDisabled = false | |||
JustinBeBoy
approved these changes
Jun 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.