Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow user to show/hide wallet balance #873

Merged
merged 3 commits into from Dec 5, 2021
Merged

Allow user to show/hide wallet balance #873

merged 3 commits into from Dec 5, 2021

Conversation

JustinBeBoy
Copy link
Contributor

Resolve #854

This PR allow user show or hide wallet balance

dreacot
dreacot suggested changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@dreacot dreacot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. on first launch the balance is hidden, the balance should be visible on first launch of the app

  1. let the hide balance be closer to the balance, that's the approved design

Screenshot 2021-11-09 at 4 24 23 PM

Decred Wallet/Features/Overview/OverviewViewController.swift Outdated Show resolved Hide resolved
@dreacot dreacot merged commit 65f4fca into planetdecred:master Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreacot dreacot dreacot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

button to show/hide wallet balance
2 participants
@JustinBeBoy @dreacot