Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

biometrics using Touch ID/ Face ID for spending password/PIN #883

Merged
merged 5 commits into from Apr 8, 2022
Merged

biometrics using Touch ID/ Face ID for spending password/PIN #883

merged 5 commits into from Apr 8, 2022

Conversation

JustinBeBoy
Copy link
Contributor

Resolve #632
This PR updated:

  • Allow user using biometrics is option for spending password/PIN
  • Add setting biometrics for spending password/PIN
  • Refactor code

Screenshot

macsleven
macsleven suggested changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@macsleven macsleven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

App crashed when launched on customTabMenuView.
line 57: (self.subviews[previousTabId] as! TabMenuItemView).deactivate()

macsleven
macsleven previously requested changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@macsleven macsleven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Biometrics needs to be implemented here
Screenshot 2021-09-27 at 21 59 44

Screenshot 2021-09-27 at 21 59 44

Screenshot 2021-09-27 at 21 59 44

Screenshot 2021-09-27 at 21 59 44

@Clariceco
Copy link

For consistency purposes, can you please capitalize "password". I have circled it in red. Thank you! Screen Shot 2022-02-04 at 12 19 38 PM

@dreacot dreacot requested a review from macsleven April 8, 2022 16:56
@dreacot dreacot merged commit 51278a6 into planetdecred:master Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreacot dreacot dreacot approved these changes

@macsleven macsleven Awaiting requested review from macsleven

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fingerprint option to wallet security
4 participants
@JustinBeBoy @Clariceco @macsleven @dreacot