Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Side and Top page Navigation button does not display Ripple effect #573

Closed
Sirmorrison opened this issue Aug 20, 2021 · 2 comments
Closed
Assignees
Labels
bug Something isn't working
Projects

Comments

@Sirmorrison
Copy link
Contributor

The highlight ripple animation doesn't show when the side and top page nav buttons are pressed, unlike other clickables.

  • To demonstrate the effected we are talking about, go to the transactions page, press and hold on a transaction. This should display a dark overlay effect.

from troubleshooting done, this is as a result of the card used to show the selected page. it overlays on the button therefore hiding the button effect.

PR #563 should fix the issue with the card display.

@Sirmorrison Sirmorrison added the bug Something isn't working label Aug 20, 2021
@Sirmorrison Sirmorrison added this to To do in godcr board Aug 20, 2021
@devchoplife
Copy link
Contributor

#563 fixes this but I noticed the overlay effect does not stay within the borders of each transaction
See below:
Screenshot from 2021-08-21 15-49-03

@Sirmorrison Sirmorrison self-assigned this Aug 22, 2021
@Sirmorrison
Copy link
Contributor Author

Sirmorrison commented Aug 23, 2021

#563 only offers a solution not the fix. Also the issue with the overlay has been resolved in #559.

@Sirmorrison Sirmorrison moved this from To do to In Progress in godcr board Aug 24, 2021
godcr board automation moved this from In Progress to Done Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
godcr board
  
Done
Development

No branches or pull requests

2 participants