Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top-level setting page UI v2 update #1035

Merged
merged 14 commits into from Aug 22, 2022

Conversation

JustinBeBoy
Copy link
Contributor

@JustinBeBoy JustinBeBoy commented Aug 6, 2022

Resolve #1031 #993 #994
Fix #1012
Fix #1013

Subtask:

  • Update v2 design for top-level setting page
  • Update modal for top-level setting page
  • Update v2 design for help page
  • Update v2 design for about page
  • Update v2 design for license

Screenshots

222222

1111111

33333

4444

image

66666

image

@JustinBeBoy JustinBeBoy marked this pull request as ready for review August 8, 2022 08:16
Copy link
Collaborator

@dreacot dreacot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The max width of the content area should be reduced
Screenshot from 2022-08-08 13-40-04

vs

Screenshot from 2022-08-08 13-40-27

This PR doesn't seem to solve #994 as stated

This PR links to a PR that closes #993, but the issue is also not resolved here, there's also a new mockup for said issue here https://www.figma.com/file/e0cYaAzkXyXXPY00v23cQY/GoDCR-%26-DCRMobile?node-id=4659%3A182253

@JustinBeBoy
Copy link
Contributor Author

This PR doesn't seem to solve #994 as stated

This PR links to a PR that closes #993, but the issue is also not resolved here, there's also a new mockup for said issue here https://www.figma.com/file/e0cYaAzkXyXXPY00v23cQY/GoDCR-%26- DCRMobile?node-id=4659%3A182253

@dreacot
The design of the top level setting has been changed, the functions divided for the wallet setting page, issues #993 and #994 are no longer needed and should be closed under this PR.

ui/modal/info_modal.go Show resolved Hide resolved
ui/page/about_page.go Outdated Show resolved Hide resolved
ui/page/about_page.go Outdated Show resolved Hide resolved
ui/page/about_page.go Outdated Show resolved Hide resolved
ui/page/help_page.go Outdated Show resolved Hide resolved
ui/page/settings_page.go Outdated Show resolved Hide resolved
ui/page/settings_page.go Outdated Show resolved Hide resolved
ui/page/settings_page.go Outdated Show resolved Hide resolved
ui/page/settings_page.go Outdated Show resolved Hide resolved
ui/page/settings_page.go Outdated Show resolved Hide resolved
@monsa00 monsa00 added this to In Progress in godcr board via automation Aug 11, 2022
@monsa00 monsa00 moved this from In Progress to needs review in godcr board Aug 11, 2022
Copy link
Contributor

@devchoplife devchoplife left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sunshine icon should be visible when dark mode is active and the moon icon when light mode is active.

image

vs

Mockup:
image

godcr board automation moved this from needs review to In Progress Aug 13, 2022
ui/modal/info_modal.go Show resolved Hide resolved
ui/values/localizable/fr.go Outdated Show resolved Hide resolved
ui/values/localizable/es.go Outdated Show resolved Hide resolved
ui/values/localizable/fr.go Show resolved Hide resolved
Copy link
Contributor

@devchoplife devchoplife left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good but a few things are out of place:

  • The moon icon should be the dark shade and the sunshine icon should be the light shade. I think you might need to extract the black moon icon and the light sunshine icon on figma.
    image

image

  • On the about page, the license row blends into the background when hovered, maybe adding a shadow could help (this only happens in light mode)

image

@JustinBeBoy
Copy link
Contributor Author

On the about page, the license row blends into the background when hovered, maybe adding a shadow could help (this only happens in light mode)

I think we should change all hover color, because all button in app occur and it is other issue

@dreacot
Copy link
Collaborator

dreacot commented Aug 16, 2022

On the about page, the license row blends into the background when hovered, maybe adding a shadow could help (this only happens in light mode)

I think we should change all hover color, because all button in app occur and it is other issue

I agree, an issue for created for this and it can be treated separately

dreacot
dreacot previously approved these changes Aug 16, 2022
Copy link
Collaborator

@dreacot dreacot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devchoplife
Copy link
Contributor

Please correct the layout of the license page:

image

vs

image

Copy link
Contributor

@crux25 crux25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this line

pg.updateSettingOptions()

From the Layout function to

func (pg *SettingsPage) OnNavigatedTo() {

The layout function is called each time there is a layout change or an action is fired so performing all that computation each time an event occurs will lag the UI.

ui/page/settings_page.go Outdated Show resolved Hide resolved
@devchoplife
Copy link
Contributor

Also, I think the color of the text we have on the license page is lighter than what we have on the mockup.

Mockup -- Godcr
image

@JustinBeBoy
Copy link
Contributor Author

Also, I think the color of the text we have on the license page is lighter than what we have on the mockup.

Mockup -- Godcr image

it's done

@JustinBeBoy JustinBeBoy moved this from In Progress to needs review in godcr board Aug 22, 2022
Copy link
Contributor

@Sirmorrison Sirmorrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

godcr board automation moved this from needs review to Approved Aug 22, 2022
@Sirmorrison Sirmorrison merged commit 21267ec into planetdecred:master Aug 22, 2022
godcr board automation moved this from Approved to Done Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
godcr board
  
Done
Development

Successfully merging this pull request may close these issues.

Update Top Level Settings to v2
5 participants