Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send new ui #320

Merged
merged 20 commits into from Mar 23, 2021
Merged

Send new ui #320

merged 20 commits into from Mar 23, 2021

Conversation

Sirmorrison
Copy link
Contributor

@Sirmorrison Sirmorrison commented Feb 16, 2021 •
edited

Fix #313
Implements send page new ui mockup
This PR implements the new mock up design for send page (address only functionality).

@Sirmorrison Sirmorrison marked this pull request as ready for review March 4, 2021 06:51
@Sirmorrison Sirmorrison force-pushed the send_newui branch 4 times, most recently from ac191da to 2c9e36d Compare March 10, 2021 22:19
@oshorefueled
Copy link
Contributor

The "Next" button should be greyed out when input fields are empty or incomplete.
Screenshot 2021-03-11 at 15 35 24

  • I can still type in the amount input field after clicking the next button and seeing confirm modal
  • The button should read "Send 1.xxxxxxxx DCR" not just "1.xxxxxx DCR".

Screenshot 2021-03-11 at 15 38 04

  • The dollar equivalent of the inputted dcr is missing from the modal. See screenshot of mockup below.
    Screenshot 2021-03-11 at 15 40 46

  • An error shouldn't be displayed on the input field after executing a transaction

Screenshot 2021-03-11 at 15 57 03

@Sirmorrison
Copy link
Contributor Author 

* The dollar equivalent of the inputted dcr is missing from the modal. See screenshot of mockup below.

The dollar equivalent of the input decred, is only displayed when currency conversion option is set from the settings page.

@oshorefueled
Copy link
Contributor

oshorefueled commented Mar 15, 2021 •
edited

  • The colour used on info icon is wrong. It should be #3D5873
  • The cancel button "backSubpageButton" is wrong. It should also be be #3D5873
  • The background colour of the button should be #C4CBD2
  • The account selection, amount and address field seem to have different border colours and possibly different border widths
    PR:

Screenshot 2021-03-15 at 12 59 34

Mockup:
Screenshot 2021-03-15 at 13 09 19

  • The Wrong colour is used on the max button. It should be #3D5873
  • The colour used on the next button is also wrong.

Kindly go through the page for any colour or dimension discrepancy with the mockup

@Sirmorrison Sirmorrison force-pushed the send_newui branch 2 times, most recently from 0d48c66 to 719c715 Compare March 17, 2021 07:03
oshorefueled
oshorefueled suggested changes Mar 17, 2021
View reviewed changes
ui/decredmaterial/editor.go Outdated Show resolved Hide resolved
ui/page.go Outdated Show resolved Hide resolved
ui/page.go Outdated Show resolved Hide resolved
ui/page.go Outdated Show resolved Hide resolved
ui/decredmaterial/theme.go Outdated Show resolved Hide resolved
ui/modal_templates.go Outdated Show resolved Hide resolved
ui/page.go Outdated Show resolved Hide resolved
ui/page.go Outdated Show resolved Hide resolved
ui/page.go Outdated Show resolved Hide resolved
wallet/wallet.go Outdated Show resolved Hide resolved
@oshorefueled
Copy link
Contributor

oshorefueled commented Mar 17, 2021 •
edited

kindly squash your commits and amend those that aren't in line with the contribution guideline

@Sirmorrison Sirmorrison force-pushed the send_newui branch 2 times, most recently from 55d05fe to f452a1a Compare March 19, 2021 15:21
@Sirmorrison
Set top navigation page option active when selected
25daea6 
* implement page header section
@Sirmorrison
add From section with dummy data
98d29c0 
* implement wallet account modal
@Sirmorrison
implement send page To section
abc8ee2 
* implement custom switch widget with text
* add address/my account toggle using custom switch widget
* add customButton to editor widget
* add destination and amount editors
* implement currency conversion functionality
* implement send amount layout with USD currency set
@Sirmorrison
add fee section with default dummy data
1c94269
@Sirmorrison
add total cost section with dummy data
58d43a3
@Sirmorrison
add confirmation modal with dummy data
ca80298
@Sirmorrison
implement DCR-USD currency conversion
bae94e2
@Sirmorrison
add error handler to bittrex exchange function
932481f 
* set default values when exchange is not fetched
* add error notification to send page ui
@Sirmorrison
update fee for every change to amount values
0c1609c 
* fix bug with calculated fee when amount is USD
* fix validation bug when the right editor is focused
* fix infinit loop bug from handleEditorChange()
* clean up code
@Sirmorrison
fix exchange error notification bug when currency is not set
e79cd10 
* add txFeeSize live data
@Sirmorrison
restore balance after send functionality
935e157
@Sirmorrison
add live data to confirmation modal
0afa62c 
* add error text to amount editor
@Sirmorrison
restore send dcr broadcast functionality
280dbf0
@Sirmorrison
implement clear all functionality
d2d1865 
* fix bug with left amount editor not displaying error
* clean up code
@Sirmorrison
fix wallet account selection bug
d8ba0fe 
* rebase pr and fix broken page after rebase
* fix lint error
@Sirmorrison
fix bug with currency swap icon display
c3d60d7 
* rebase pr
* increase switch widget margin
* fix address input field error message bug when no address is set
* fix active next button bug when inputs are empty
* fix active amount input bug when confirmation modal is open
* clean up code
@Sirmorrison
update send DCR button text to mockup design
a1df191 
* remove editor error message after dcr is sent
* scale confirmation modal send icon
* remove hardcoded selected currency value on settings page
@Sirmorrison
apply send page mock dimension
ba69569 
* align page colors to mockup colors
* add spinner icon to confirmation page
* fix blury decred logo and alignment
* rebase pr
@Sirmorrison
fix editor border color and dimension
2e5a01f 
* fix issues with dimension values
* make send page header fixed
* revert changes to decred icon
* clean up code
@Sirmorrison
use iconvg dropdown icon
1179e56 
remove exchange error channel
@oshorefueled oshorefueled merged commit 1d6a477 into planetdecred:master Mar 23, 2021
song50119 pushed a commit to song50119/godcr that referenced this pull request Apr 24, 2022
@Sirmorrison
update send page to mock up design (planetdecred#320)
f3e4cc9 
* implement page header section
* implement wallet account modal
* implement send page To section
* implement custom switch widget with text
* add address/my account toggle using custom switch widget
* add customButton to editor widget
* implement send amount layout with USD currency set
* implement DCR-USD currency conversion
* add error notification to send page ui
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oshorefueled oshorefueled oshorefueled approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update send page: Emtpy & Filled
2 participants
@Sirmorrison @oshorefueled