About page #352
Merged
About page #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oshorefueled
suggested changes
Mar 29, 2021
ui/about_page.go
Outdated
| versionValueLabel: common.theme.Body2("v1.5.2"), | ||
| buildDateLabel: common.theme.Body1("Build date"), | ||
| buildDateValueLabel: common.theme.Body2("2020-09-10"), | ||
| networkLabel: common.theme.Body1("Network"), |
There was a problem hiding this comment.
try to avoid naming your variable after its type. Your variable name should describe its content not its type. network would just be fine here.
ui/about_page.go
Outdated
| @@ -24,16 +69,108 @@ func (win *Window) AboutPage(common pageCommon) layout.Widget { | |||
| } | |||
|
|
|||
| // main settings layout | |||
There was a problem hiding this comment.
kindly add a more appropriate comment or if remove it if its unnecessary
ui/about_page.go
Outdated
| line: common.theme.Line(), | ||
| container: &layout.List{Axis: layout.Vertical}, | ||
| versionLabel: common.theme.Body1("Version"), | ||
| versionValueLabel: common.theme.Body2("v1.5.2"), |
There was a problem hiding this comment.
This should have a text size of 16sp, Body2 has a size of 14sp.
|
Current implementation: The separators should extend all the way to the right side of the card. It shouldn't be bounded by the padding. Kindly have a look at the mock design |
oshorefueled
approved these changes
Mar 30, 2021
song50119
pushed a commit
to song50119/godcr
that referenced
this pull request
Apr 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements about page of the new design.
Fixes #350
