Fix max button on send page #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oshorefueled
suggested changes
May 1, 2021
ui/compontents.go
Outdated
| bal := page.info.Wallets[page.wallAcctSelector.selectedSendWallet].Accounts[page.wallAcctSelector.selectedSendAccount].TotalBalance | ||
| return d(gtx, acctName, walName, bal, page.wallAcctSelector.sendAccountBtn) | ||
| bal := page.info.Wallets[page.wallAcctSelector.selectedSendWallet].Accounts[page.wallAcctSelector.selectedSendAccount].SpendableBalance | ||
| return d(gtx, acctName, walName, dcrutil.Amount(bal).String(), page.wallAcctSelector.sendAccountBtn) |
There was a problem hiding this comment.
set page.info.Wallets[page.wallAcctSelector.selectedSendWallet] to a variable to make the code line shorter and easier to read.
|
I still get the "insufficient balance" bug when I use the max button.
|
|
I'm currently experiencing this issue when using the button on different accounts
|
- Fill max amount when clicking the max button - Clear the Dollar Equivalence field when the DCR Amount field is also cleared, and vice versa - Clear input field error when exit send page - Show the spendable balance in the account selector widget
|
Clicking the max button take 2 or 3 seconds to populate the input field. And when I use the max button on an account with zero balance, it causes the entire window to freeze.
|
oshorefueled
approved these changes
May 20, 2021
song50119
pushed a commit
to song50119/godcr
that referenced
this pull request
May 29, 2021
song50119
pushed a commit
to song50119/godcr
that referenced
this pull request
Apr 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #393