Add tickets list page #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
song50119
force-pushed
the
implement-tickets-list
branch
from
9985742
to
bdeb27f
Compare
song50119
force-pushed
the
implement-tickets-list
branch
2 times, most recently
from
22c371d
to
a8ad94f
Compare
song50119
force-pushed
the
implement-tickets-list
branch
from
a8ad94f
to
5adf30f
Compare
oshorefueled
suggested changes
May 20, 2021
ui/util.go
Outdated
| @@ -126,3 +127,56 @@ func computePasswordStrength(pb *decredmaterial.ProgressBarStyle, th *decredmate | |||
| pb.Progress = float32(strength * 100) | |||
| pb.Color = th.Color.Success | |||
| } | |||
|
|
|||
| func ticketIconStatus(c *pageCommon, ticketStatus string) *struct { | |||
There was a problem hiding this comment.
This should be named ticketStatusIcon
ui/compontents.go
Outdated
Comment on lines
817
to
820
| wrap.Radius.NE = 8 // top - left | ||
| wrap.Radius.SW = 0 // bottom - left | ||
| wrap.Radius.NW = 8 // top - right | ||
| wrap.Radius.SE = 0 // bottom - right |
There was a problem hiding this comment.
- each corner radius doesn't have to be set on a new line. You can define the radius using the * * *
CornerRadius type on a single line and assign it once. As in
radius := decredmaterial.CornerRadius{8, 0, 8, 0}
wrap.Radius = radius
This should be applied where appropriate in other aspects of this PR.
- I believe NE (north east) is top right not top left.
- I'm not sure "ticketLiveItemnInfo" is a suitable name for this. "ticketCard" maybe?
- Can comments be added to this layout? So that it is easier to read and understood quicker.
song50119
force-pushed
the
implement-tickets-list
branch
2 times, most recently
from
5a19e94
to
3ac7df3
Compare
song50119
force-pushed
the
implement-tickets-list
branch
from
3ac7df3
to
9868a3a
Compare
oshorefueled
approved these changes
May 20, 2021
song50119
added a commit
to song50119/godcr
that referenced
this pull request
May 29, 2021
* Add progress bar for each ticket list item
song50119
added a commit
to song50119/godcr
that referenced
this pull request
Apr 24, 2022
* Add progress bar for each ticket list item
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #404