Statistics Page #445
Merged
Statistics Page #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sirmorrison
previously requested changes
May 30, 2021
There was a problem hiding this comment.
The uptime on the mockup is different from what we have implemented. From the mockup, it looks like the up time is a timer, to determine how long the app has been running.
Also, you currently have testnet3 on the Network it should read either testnet or mainnet
ui/statistics_page.go
Outdated
Comment on lines
41
to
43
| return func(gtx C) D { | ||
| return pg.theme.Separator().Layout(gtx) | ||
| } |
There was a problem hiding this comment.
Suggested change
| return func(gtx C) D { | |
| return pg.theme.Separator().Layout(gtx) | |
| } | |
| return pg.theme.Separator().Layout |
ui/statistics_page.go
Outdated
| txs **wallet.Transactions | ||
| theme *decredmaterial.Theme | ||
| l layout.List | ||
| startupTime string |
There was a problem hiding this comment.
Not needed and can be removed.
Suggested change
| startupTime string | |
ui/statistics_page.go
Outdated
| Axis: layout.Vertical, | ||
| }, | ||
| } | ||
| pg.startupTime = time.Now().String() |
There was a problem hiding this comment.
Not needed and can be removed.
Suggested change
| pg.startupTime = time.Now().String() |
ui/statistics_page.go
Outdated
| pg.lineSeparator(), | ||
| item("Peers connected", strconv.Itoa(int(pg.syncStatus.ConnectedPeers))), | ||
| pg.lineSeparator(), | ||
| item("Uptime", pg.startupTime), |
There was a problem hiding this comment.
Suggested change
| item("Uptime", pg.startupTime), | |
| item("Uptime", time.Now().String()), |
There was a problem hiding this comment.
time.Now() returns the current time, Uptime should be how long the app has been running.
ui/statistics_page.go
Outdated
Comment on lines
59
to
60
| l := pg.theme.Label(values.TextSize14, t) | ||
| r := pg.theme.Label(values.TextSize14, v) |
There was a problem hiding this comment.
Suggested change
| l := pg.theme.Label(values.TextSize14, t) | |
| r := pg.theme.Label(values.TextSize14, v) | |
| l := pg.theme.Body2(t) | |
| r := pg.theme.Body2(v) |
ui/statistics_page.go
Outdated
Comment on lines
92
to
93
| m16 := values.MarginPadding16 | ||
| return layout.Inset{Left: m16}.Layout(gtx, func(gtx C) D { |
There was a problem hiding this comment.
Suggested change
| m16 := values.MarginPadding16 | |
| return layout.Inset{Left: m16}.Layout(gtx, func(gtx C) D { | |
| return layout.Inset{Left: values.MarginPadding16}.Layout(gtx, func(gtx C) D { |
No need for the extra variable as it can fit into the Inset.
ui/statistics_page.go
Outdated
Comment on lines
108
to
110
| body: func(gtx C) D { | ||
| return pg.layoutStats(gtx) | ||
| }, |
There was a problem hiding this comment.
Suggested change
| body: func(gtx C) D { | |
| return pg.layoutStats(gtx) | |
| }, | |
| body: pg.layoutStats, |
oshorefueled
suggested changes
May 31, 2021
ui/statistics_page.go
Outdated
| pg.lineSeparator(), | ||
| item("Peers connected", strconv.Itoa(int(pg.syncStatus.ConnectedPeers))), | ||
| pg.lineSeparator(), | ||
| item("Uptime", pg.startupTime), |
There was a problem hiding this comment.
time.Now() returns the current time, Uptime should be how long the app has been running.
Closed
song50119
force-pushed
the
statistics
branch
4 times, most recently
from
f4ec5af
to
37ccba4
Compare
oshorefueled
previously approved these changes
Jun 2, 2021
- Add spacing to page - Show network name, bestblock, data directory, wallet data size, number of txs and wallet
- Use theme Separator in layout widget slice - Correct uptime value - Change network name with suffix to actual name - Refresh frame for each 1 second
oshorefueled
dismissed
Sirmorrison’s stale review
requested changes have been resolved
oshorefueled
approved these changes
Jun 3, 2021
tuhalang
pushed a commit
to tuhalang/godcr
that referenced
this pull request
Jun 5, 2021
* Refactor Statistics Page - Show network name, bestblock, data directory, wallet data size, number of txs and wallet * Use theme Separator widget to layout page list - Correct uptime value - Change network name with suffix to actual name - Refresh frame after 1 second to update the uptime value
song50119
added a commit
to song50119/godcr
that referenced
this pull request
Apr 24, 2022
* Refactor Statistics Page - Show network name, bestblock, data directory, wallet data size, number of txs and wallet * Use theme Separator widget to layout page list - Correct uptime value - Change network name with suffix to actual name - Refresh frame after 1 second to update the uptime value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continue process #423