Add modal interface and migrate existing modals #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use create password modal to handle create wallet, create startup passphrase & change pass - modify password dialog to accomdate other templates
- protect modal stack with a mutex - generate random unique ids for modals
dreacot
previously approved these changes
Jun 6, 2021
oshorefueled
suggested changes
Jun 9, 2021
oshorefueled
approved these changes
Jun 10, 2021
Closed
song50119
pushed a commit
to song50119/godcr
that referenced
this pull request
Apr 24, 2022
* Add modal interface * Add info modal and backwards compatibility for modal templates * Add create password modal - use create password modal to handle create wallet, create startup passphrase & change pass - modify password dialog to accommodate other templates * Add text input dialog to handle simple text inputs * Implement add account modal using text input and info modals - add mutex to access modal list * Move modals to mainPage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds a
Modalinterface, an interface for creating and managing custom modals made to replace the current modal manager which uses a global instance for all modals. AshowModal&dismissModalfunction is also added to MainPage and made available to all pages viapageCommonl. TheshowModalfunction allows displaying multiple modals at once which are stacked on each other and ordered with the latest modal on top anddismissModalhelps with dismissing a specific modal.