Use dcrlibwallet directly in overview and transactions page #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Clicking on one clickable text on the transaction details page triggers a click on another
There's also a slight navigation delay when navigating from any page to the overview page |
beansgum
force-pushed
the
overview_dcrlib
branch
from
004b15e
to
3a19be4
Compare
- add changeFragment function to main page for adding new page instances - pass transaction object to transaction details page directly
beansgum
force-pushed
the
overview_dcrlib
branch
from
3a19be4
to
d047098
Compare
oshorefueled
approved these changes
Jun 19, 2021
song50119
pushed a commit
to song50119/godcr
that referenced
this pull request
Apr 24, 2022
…cred#475) * Start sync from main page and update overview from sync notifications * overview: fetch transactions directly from dcrlibwallet - add changeFragment function to main page for adding new page instances - pass transaction object to transaction details page directly * transactions: fetch, filter and sort transactions using dcrlibwallet * Implement new transactions notification in overview page * Implement sync notification in transactions page * Add wallets parameter to wallet drop down selector * Add OnResume lifecycle callback to pages * overview: load transactions in OnResume * Use latest dcrlibwallet version (f776ef6) * Use wallet.AccountName to fetch tx input account - simplify tx output/input code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change removes the use of global transactions data to populate the layout of overview, transactions and transaction details page. The transactions are now fetched from dcrlibwallet when the page is initially loaded and the list is refreshed whenever a transaction notification is received.