Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement backstack history for pages #557

Merged
merged 7 commits into from Aug 17, 2021

Conversation

beansgum
Copy link
Contributor

@beansgum beansgum commented Aug 16, 2021

Closes #497
This pr fixes the unresponsive back button in some subpages and also adds a PopFragment() function changes to the previous page while retaining the page state.

@beansgum beansgum marked this pull request as ready for review August 16, 2021 18:28
Copy link
Contributor

@Sirmorrison Sirmorrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks good.

@Sirmorrison Sirmorrison added this to Review in progress in godcr board Aug 17, 2021
godcr board automation moved this from Review in progress to Approved Aug 17, 2021
@oshorefueled oshorefueled merged commit bacb38a into planetdecred:master Aug 17, 2021
godcr board automation moved this from Approved to Done Aug 17, 2021
@beansgum beansgum deleted the backstack branch August 17, 2021 08:55
beansgum pushed a commit to beansgum/godcr that referenced this pull request Aug 17, 2021
song50119 pushed a commit to song50119/godcr that referenced this pull request Apr 24, 2022
* Add ID() to Pages interface

* main page: make struct variables private

* Add PageID property to NavHandler

* Remove id parameter from ChangeFragment function

* use PopFragment in Back() of sub pages

* Add popToPage to skip pages in backstack
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
godcr board
  
Done
Development

Successfully merging this pull request may close these issues.

Issue going back to main starting page after opening multiple nested sub pages.
4 participants