Format transactions row and details #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sirmorrison
suggested changes
Aug 27, 2021
| AboutIcon, DebugIcon, VerifyMessageIcon, LocationPinIcon, AlertGray, ArrowDownIcon, | ||
| WatchOnlyWalletIcon, CurrencySwapIcon, SyncingIcon, ProposalIconActive, ProposalIconInactive, | ||
| Restore, DocumentationIcon, DownloadIcon, TimerIcon, TicketIcon, TicketIconInactive, StakeyIcon, | ||
| List, ListGridIcon, DecredSymbolIcon *widget.Image | ||
| List, ListGridIcon, DecredSymbolIcon, DecredSymbol2 *widget.Image |
There was a problem hiding this comment.
Rename DecredSymbol2 to DecredSymbolIconTwo
| ImportedAccountIcon, AccountIcon, EditIcon, expandIcon, CopyIcon, mixer, MixerSmall, | ||
| ArrowForwardIcon, TransactionFingerPrintIcon, SettingsIcon, SecurityIcon, HelpIcon, | ||
| ImportedAccountIcon, AccountIcon, EditIcon, expandIcon, CopyIcon, MixedTx, mixer, MixerSmall, | ||
| ArrowForwardIcon, Next, TransactionFingerPrintIcon, SettingsIcon, SecurityIcon, HelpIcon, |
There was a problem hiding this comment.
It's redundant to have Icon in the variable since the struct name already contains that.
| @@ -40,14 +40,14 @@ type Icons struct { | |||
| ImageBrightness1, ContentClear, DropDownIcon, Cached, ContentRemove *widget.Icon | |||
|
|
|||
| OverviewIcon, OverviewIconInactive, WalletIcon, WalletIconInactive, | |||
| ReceiveIcon, TransactionIcon, TransactionIconInactive, SendIcon, MoreIcon, MoreIconInactive, | |||
| ReceiveIcon, Transferred, TransactionIcon, TransactionIconInactive, SendIcon, MoreIcon, MoreIconInactive, | |||
There was a problem hiding this comment.
Transferred to TransferredIcon
oshorefueled
suggested changes
Aug 27, 2021
oshorefueled
suggested changes
Aug 27, 2021
ui/page/transaction_details_page.go
Outdated
Comment on lines
662
to
663
| func (pg *TransactionDetailsPage) separator(gtx layout.Context) layout.Dimensions { | ||
| m := values.MarginPadding5 | ||
| return layout.Inset{Top: m, Bottom: m}.Layout(gtx, pg.theme.Separator().Layout) | ||
| return pg.theme.Separator().Layout(gtx) |
There was a problem hiding this comment.
Is this separator wrapper needed?
oshorefueled
approved these changes
Aug 27, 2021
Sirmorrison
approved these changes
Aug 30, 2021
song50119
pushed a commit
to song50119/godcr
that referenced
this pull request
Apr 24, 2022
* Format transactions row for various tx types * transactions: add mixed transaction type to dropdown selector * transactions: display denomination and mix count for mixed transactions * Support formatting amount with different text sizes and scale * transactions: display mix denomination in transaction row * transactions: show number of days ticket took to vote or revoke * transactions: show vote reward and ticket price price for stake transactions * tx details: add button to view associated ticket * tx detais: fix padding and margins for rows and page sections * tx details: show ticket status, days to vote and vote reward * tx details: add maturity progress bar * Remove redundant seperator function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #561