New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split combined backup flow to multiple pages and cleanup interface design #587
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a clean up PR,
When the page is expanded, the verify button is overly large in width.
Following recent review by Raedah, the button should have a maximum with which is preferably the width of the button on the default screen.
-
the button color when it is grayed out does not correspond to the other buttons on the app.
the color should bet.Color.InactiveGray = rgb(0xc4cbd2)
-
On the Write down seed phrase page, the confirm button is also overly large on full screen. it should have a maximum width and center aligned with the text on full screen.
-
On the seed phrase page, the action button width is overly expanded also and the color is not uniform to the application (see recommended color above.
-
Then i noticed a pattern with the seed phrase arrangement. it does not seem to be random as it has a pattern. The first 10 are on thesame line, the next 10 on the next line and so on...
- Clicking on the back button on the back button on the
Verify seed phrase page 2/2
page takes me back to thewallet page
instead ofpage 1/2
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…sign (planetdecred#587) * Move seed backup page to seedbackup package * Add backup instructions page * Add save seed page * Add seed verification page * Add backup success page * Remove combined seed backup page * Fix modified seed slice when passed to shuffle function * Add seperator before fixed bottom pane * Fix large bottom pane * Fix disabled button color * Prompt before exiting backup process
This pr adds a new package
seedbackup
and splits the seed backup page into backup instructions page, save seed page, verify seed page, and backup success page. The user interface is also cleaned up to apply proper styling and dimensions.