Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split combined backup flow to multiple pages and cleanup interface design #587

Merged
merged 11 commits into from Sep 7, 2021

Conversation

beansgum
Copy link
Contributor

@beansgum beansgum commented Sep 1, 2021

This pr adds a new package seedbackup and splits the seed backup page into backup instructions page, save seed page, verify seed page, and backup success page. The user interface is also cleaned up to apply proper styling and dimensions.

@oshorefueled
Copy link
Contributor

There should probably be a little bit of space between the fixed bottom pane and the side navigation similar to how it's done on the send page.

Current Seed backup implementation

Screenshot 2021-09-01 at 21 28 10

Send page mockup

Screenshot 2021-09-01 at 20 54 48

oshorefueled
oshorefueled previously approved these changes Sep 3, 2021
Copy link
Contributor

@Sirmorrison Sirmorrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a clean up PR,

When the page is expanded, the verify button is overly large in width.
Following recent review by Raedah, the button should have a maximum with which is preferably the width of the button on the default screen.

image

this button size is perfect
image

  • the button color when it is grayed out does not correspond to the other buttons on the app.
    the color should be t.Color.InactiveGray = rgb(0xc4cbd2)

  • On the Write down seed phrase page, the confirm button is also overly large on full screen. it should have a maximum width and center aligned with the text on full screen.
    image

  • On the seed phrase page, the action button width is overly expanded also and the color is not uniform to the application (see recommended color above.

  • Then i noticed a pattern with the seed phrase arrangement. it does not seem to be random as it has a pattern. The first 10 are on thesame line, the next 10 on the next line and so on...
    image

image

image

  • Clicking on the back button on the back button on the Verify seed phrase page 2/2 page takes me back to the wallet page instead of page 1/2.

ui/page/components/sub_page.go Outdated Show resolved Hide resolved
ui/page/seedbackup/backup_instructions.go Outdated Show resolved Hide resolved
ui/page/seedbackup/backup_instructions.go Outdated Show resolved Hide resolved
ui/page/seedbackup/backup_success.go Outdated Show resolved Hide resolved
ui/page/seedbackup/verify_seed.go Outdated Show resolved Hide resolved
ui/page/seedbackup/verify_seed.go Outdated Show resolved Hide resolved
Copy link
Contributor

@Sirmorrison Sirmorrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Clicking on the back button on the back button on the Verify seed phrase page 2/2 page takes me back to the wallet page instead of page 1/2. (see screen recording below.)
    ezgif com-gif-maker(4)

  • furthermore, this issues is only noticed on windows machine for me.. On Mac it seems to work fine.

image

ui/page/components/sub_page.go Outdated Show resolved Hide resolved
@dreacot dreacot merged commit 497c15c into planetdecred:master Sep 7, 2021
@dreacot dreacot deleted the backup_page branch September 7, 2021 13:32
@dreacot dreacot restored the backup_page branch September 7, 2021 13:33
song50119 pushed a commit to song50119/godcr that referenced this pull request Apr 24, 2022
…sign (planetdecred#587)

* Move seed backup page to seedbackup package

* Add backup instructions page

* Add save seed page

* Add seed verification page

* Add backup success page

* Remove combined seed backup page

* Fix modified seed slice when passed to shuffle function

* Add seperator before fixed bottom pane

* Fix large bottom pane

* Fix disabled button color

* Prompt before exiting backup process
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants