Update currency and language setting on the Setting page #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- get setting of language and currency when start app
JustinBeBoy
force-pushed
the
update_modal
branch
from
0eee948
to
9898ea5
Compare
Sirmorrison
suggested changes
Sep 14, 2021
There was a problem hiding this comment.
This methods are no longer needed.
godcr/ui/preference/list_preference.go
Line 77 in 9898ea5
godcr/ui/preference/list_preference.go
Line 84 in 9898ea5
godcr/ui/preference/list_preference.go
Line 187 in 9898ea5
ui/preference/list_preference.go
Outdated
| titleStrKey string | ||
| items map[string]string //[key]str-key | ||
| itemKeys []string | ||
| isAutoUpdate bool |
There was a problem hiding this comment.
This is redundant. What exactly is it supposed to be used for?
There was a problem hiding this comment.
It use to add title for modal
There was a problem hiding this comment.
I was referring to the isAutoUpdate
dreacot
requested changes
Sep 15, 2021
Sirmorrison
suggested changes
Sep 15, 2021
ui/preference/list_preference.go
Outdated
| lp.setValue(lp.optionsRadioGroup.Value) | ||
| lp.IsShowing = false | ||
| lp.updateButtonClicked() | ||
|
|
JustinBeBoy
force-pushed
the
update_modal
branch
from
60d186f
to
a460b46
Compare
Sirmorrison
approved these changes
Sep 15, 2021
dreacot
approved these changes
Sep 15, 2021
song50119
pushed a commit
to song50119/godcr
that referenced
this pull request
Apr 24, 2022
…d#626) * remove cancel and confirm buttons from the setting page language and currency modal - get setting of language and currency when start app - remove methods redundant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolve #603