Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds hide balance button #646

Merged
merged 11 commits into from Oct 21, 2021
Merged

Adds hide balance button #646

merged 11 commits into from Oct 21, 2021

Conversation

AdimekweEbuka
Copy link
Contributor

@AdimekweEbuka AdimekweEbuka commented Sep 27, 2021 •
edited

This PR adds a hide balance button to main page.
Closes #639

godcr-testnet-2021-10-16-21-18-4

beansgum
beansgum previously requested changes Sep 27, 2021
View reviewed changes
ui/page/main_page.go Outdated Show resolved Hide resolved
ui/page/main_page.go Outdated Show resolved Hide resolved
ui/page/main_page.go Outdated Show resolved Hide resolved
ui/page/main_page.go Outdated Show resolved Hide resolved
ui/page/main_page.go Outdated Show resolved Hide resolved
ui/page/main_page.go Outdated Show resolved Hide resolved
ui/page/main_page.go Outdated Show resolved Hide resolved
ui/page/main_page.go Outdated Show resolved Hide resolved
Sirmorrison
Sirmorrison suggested changes Sep 27, 2021
View reviewed changes
ui/page/main_page.go Outdated Show resolved Hide resolved
ui/page/main_page.go Outdated Show resolved Hide resolved
@Sirmorrison Sirmorrison added this to In Progress in godcr board via automation Sep 27, 2021
@raedah
Copy link
Contributor

raedah commented Sep 27, 2021

This can be an option in the settings instead so it doesn't take up visual space for users who don't need it.

@AdimekweEbuka
Copy link
Contributor Author

New commit moves hides balance to settings page
godcr (testnet) 2021-09-29 23-11-19

godcr board automation moved this from In Progress to Review in progress Oct 4, 2021
Sirmorrison
Sirmorrison suggested changes Oct 4, 2021
View reviewed changes
ui/page/main_page.go Outdated Show resolved Hide resolved
ui/page/main_page.go Outdated Show resolved Hide resolved
ui/page/main_page.go Outdated Show resolved Hide resolved
ui/page/main_page.go Outdated Show resolved Hide resolved
ui/page/main_page.go Outdated Show resolved Hide resolved
ui/page/main_page.go Outdated Show resolved Hide resolved
ui/page/settings_page.go Outdated Show resolved Hide resolved
@Sirmorrison
Copy link
Contributor

Sirmorrison commented Oct 4, 2021 •
edited

Update to the UI.
image

image

it should also have tooltip hover.

@AdimekweEbuka
Copy link
Contributor Author

Update to the UI. image

image

it should also have tooltip hover.

I like this a lot but I thought the hide button function was to be placed in the settings page

@dreacot
Copy link
Collaborator

dreacot commented Oct 4, 2021 •
edited by Sirmorrison

Update to the UI. image
image
it should also have tooltip hover.

I like this a lot but I thought the hide button function was to be placed in the settings page

The provided UI is the approved design

@AdimekweEbuka
Copy link
Contributor Author

AdimekweEbuka commented Oct 4, 2021 •
edited by Sirmorrison

Update to the UI. image
image
it should also have tooltip hover.

I like this a lot but I thought the hide button function was to be placed in the settings page

The provided UI is the approved design

Seen, would address accordingly. Thanks

@AdimekweEbuka
Copy link
Contributor Author

New commit implements the UI update excluding the tooltip feature
godcr (testnet) 2021-10-12 18-18-38

Sirmorrison
Sirmorrison suggested changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@Sirmorrison Sirmorrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR failed to build with the error
image

Further more.... the hide and display button works however, the state is not save.

When i hide the balance, exit the app and launch it again, my settings reverts and my balance is visible again.

ui/page/main_page.go Outdated Show resolved Hide resolved
ui/page/main_page.go Outdated Show resolved Hide resolved
dreacot
dreacot requested changes Oct 15, 2021
View reviewed changes
Copy link
Collaborator

@dreacot dreacot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. If currency conversion is enabled, the icon is between the DCR balance and USD balance, it should be put after the USD balance as seen on the mockup

Screenshot 2021-10-15 at 10 09 15 AM

  1. From the mockup DCR should be suffixed after the hidden balance

What you have?
Screenshot 2021-10-15 at 10 09 42 AM

What the mockup says
Screenshot 2021-10-15 at 10 15 03 AM

ui/load/load.go Outdated Show resolved Hide resolved
ui/page/main_page.go Outdated Show resolved Hide resolved
ui/page/main_page.go Outdated Show resolved Hide resolved
ui/page/main_page.go Outdated Show resolved Hide resolved
ui/page/main_page.go Outdated Show resolved Hide resolved
ui/page/main_page.go Outdated Show resolved Hide resolved
ui/page/main_page.go Outdated Show resolved Hide resolved
ui/page/main_page.go Outdated Show resolved Hide resolved
ui/page/main_page.go Outdated Show resolved Hide resolved
dreacot
dreacot requested changes Oct 16, 2021
View reviewed changes
ui/page/main_page.go Outdated Show resolved Hide resolved
ui/page/main_page.go Outdated Show resolved Hide resolved
ui/page/main_page.go Outdated Show resolved Hide resolved
ui/page/main_page.go Outdated Show resolved Hide resolved
ui/page/main_page.go Outdated Show resolved Hide resolved
@dreacot dreacot dismissed a stale review October 16, 2021 17:26

was meant to request change not approve

dreacot
dreacot requested changes Oct 16, 2021
View reviewed changes
ui/page/main_page.go Outdated Show resolved Hide resolved
dreacot
dreacot previously approved these changes Oct 16, 2021
View reviewed changes
ui/page/main_page.go Outdated Show resolved Hide resolved
ui/page/main_page.go Outdated Show resolved Hide resolved
dreacot
dreacot requested changes Oct 16, 2021
View reviewed changes
ui/page/main_page.go Outdated Show resolved Hide resolved
ui/page/main_page.go Outdated Show resolved Hide resolved
ui/page/main_page.go Outdated Show resolved Hide resolved
@devchoplife
Copy link
Contributor

Works fine on my end too
Hides USD balance when the hide balance button is clicked

dreacot
dreacot requested changes Oct 16, 2021
View reviewed changes
ui/page/main_page.go Outdated Show resolved Hide resolved
dreacot
dreacot previously requested changes Oct 21, 2021
View reviewed changes
Copy link
Collaborator

@dreacot dreacot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If currency conversion is disabled, then the hide balance tootlip has excess left padding

Screenshot from 2021-10-21 14-47-12

@Sirmorrison Sirmorrison dismissed stale reviews from dreacot and beansgum October 21, 2021 15:43

resolved

godcr board automation moved this from Review in progress to Approved Oct 21, 2021
@Sirmorrison Sirmorrison merged commit e526b8b into planetdecred:master Oct 21, 2021
godcr board automation moved this from Approved to Done Oct 21, 2021
song50119 pushed a commit to song50119/godcr that referenced this pull request Apr 24, 2022
@AdimekweEbuka @dreacot @Sirmorrison
Adds hide balance button (planetdecred#646)
81679b1 
* Adds hide balance button

* Moves Hide balance to settings page

* Implements a hide/show balance icon button on main page

* Removes USD balance when balance is hidden

* Resolves HideBalanceConfigKey string value

* add tooltip to hide balance icon

* fix hidden balance tooltip hover

* comment out hidden balance label/tooltip

Co-authored-by: dreacot <kennedyizuegbu@yahoo.com>
Co-authored-by: sirmorrison <edonomorrison@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sirmorrison Sirmorrison Sirmorrison approved these changes

@beansgum beansgum beansgum left review comments

@dreacot dreacot dreacot left review comments

Assignees
No one assigned
Labels
None yet
Projects
godcr board
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

button to show/hide wallet balance
6 participants
@AdimekweEbuka @raedah @Sirmorrison @dreacot @devchoplife @beansgum