Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates unconfirmed funds modal #712

Merged
merged 10 commits into from Dec 14, 2021
Merged

Updates unconfirmed funds modal #712

merged 10 commits into from Dec 14, 2021

Conversation

AdimekweEbuka
Copy link
Contributor

@AdimekweEbuka AdimekweEbuka commented Dec 8, 2021 •
edited

PR to solve #707
godcr (testnet) 2021-12-12 20-07-49

@AdimekweEbuka AdimekweEbuka marked this pull request as ready for review December 9, 2021 01:46
devchoplife
devchoplife suggested changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@devchoplife devchoplife left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The size of the info icon should be increased a bit.
Screenshot from 2021-12-09 11-18-27

Sirmorrison
Sirmorrison suggested changes Dec 9, 2021
View reviewed changes
ui/modal/info_modal.go Outdated Show resolved Hide resolved
ui/modal/info_modal.go Outdated Show resolved Hide resolved
devchoplife
devchoplife suggested changes Dec 12, 2021
View reviewed changes
ui/modal/info_modal.go Outdated Show resolved Hide resolved
ui/modal/info_modal.go Outdated Show resolved Hide resolved
ui/modal/info_modal.go Outdated Show resolved Hide resolved
ui/modal/info_modal_layouts.go Outdated Show resolved Hide resolved
ui/modal/text_input_modal.go Outdated Show resolved Hide resolved
ui/page/wallets/privacy_page.go Outdated Show resolved Hide resolved
ui/page/wallets/privacy_page.go Show resolved Hide resolved
ui/modal/info_modal.go Outdated Show resolved Hide resolved
@devchoplife
Copy link
Contributor

Please add an image to the PR description and rebase as PR has conflicts
@AdimekweEbuka

Sirmorrison
Sirmorrison suggested changes Dec 14, 2021
View reviewed changes
ui/page/wallets/privacy_page.go Outdated Show resolved Hide resolved
ui/modal/info_modal_layouts.go Outdated Show resolved Hide resolved
ui/modal/info_modal_layouts.go Outdated Show resolved Hide resolved
ui/modal/text_input_modal.go Outdated Show resolved Hide resolved
ui/page/wallets/privacy_page.go Outdated Show resolved Hide resolved
@dreacot
Copy link
Collaborator

dreacot commented Dec 14, 2021

why isn't the confirm button blue?

also noticed that the input accepts white spaces, white spaces should be trimmed

@Sirmorrison
Copy link
Contributor

Sirmorrison commented Dec 14, 2021 •
edited

why isn't the confirm button blue?

also noticed that the input accepts white spaces, white spaces should be trimmed

image

its the mockup design. Its a danger zone.

@AdimekweEbuka
Copy link
Contributor Author

why isn't the confirm button blue?

also noticed that the input accepts white spaces, white spaces should be trimmed

Looking through, majority of the editors accept whitespace input, another issue could be opened to tackle this.

@dreacot
Copy link
Collaborator

dreacot commented Dec 14, 2021

why isn't the confirm button blue?
also noticed that the input accepts white spaces, white spaces should be trimmed

Looking through, majority of the editors accept whitespace input, another issue could be opened to tackle this.

alright noted, we can do that

Sirmorrison
Sirmorrison suggested changes Dec 14, 2021
View reviewed changes
ui/modal/info_modal_layouts.go Outdated Show resolved Hide resolved
ui/modal/info_modal_layouts.go Outdated Show resolved Hide resolved
@Sirmorrison Sirmorrison merged commit a27adb4 into planetdecred:master Dec 14, 2021
song50119 pushed a commit to song50119/godcr that referenced this pull request Apr 24, 2022
@AdimekweEbuka
Updates unconfirmed funds modal (planetdecred#712)
52dbc06 
* Create modal using text input modal

* Update unconfirmed funds modal

* Final update to unconfirmed funds modal

* Clean up code, removes white spaces and indentations

* Clean up code and resolves conflict

* Fix build error

* Adjust template function and modal icon

* Correct text.color comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devchoplife devchoplife devchoplife requested changes

@Sirmorrison Sirmorrison Sirmorrison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AdimekweEbuka @devchoplife @dreacot @Sirmorrison