Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: grpc #16

Closed
srikrsna opened this issue Jul 11, 2021 · 2 comments
Closed

Question: grpc #16

srikrsna opened this issue Jul 11, 2021 · 2 comments

Comments

@srikrsna
Copy link

One of the features (which is on by default if features are not specified) is grpc. A quick look at the code and I can't seem to find any difference between the regular grpc plugin and the code generated vtprotobuf. Is there a plan to extends this to use say use pool for object creation in the future?

@vmg
Copy link
Member

vmg commented Jul 13, 2021

Hey @srikrsna! The GRPC plugin is still experimental, but it does already support using pools for object creation -- that's the whole point of it. It generates boilerplate code which is identical to the upstream GRPC compiler, but where any objects that have been configured to be memory pooled are allocated from a pool. Are you failing to see this behavior in practice, or did you just miss it while reviewing the implementation?

@srikrsna
Copy link
Author

I added pool as an option to the features directly. I guess I need to explicitly specify pool option against the messages I want to pool.

Thank you for the clarification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants