Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unknown feature: "clone" #74

Closed
delaneyj opened this issue Jan 4, 2023 · 2 comments
Closed

unknown feature: "clone" #74

delaneyj opened this issue Jan 4, 2023 · 2 comments

Comments

@delaneyj
Copy link

delaneyj commented Jan 4, 2023

Works fine...

--go-vtproto_opt=features=marshal+unmarshal+size+pool \

Making sure to get latest go install github.com/planetscale/vtprotobuf/cmd/protoc-gen-go-vtproto@latest

--go-vtproto_opt=features=marshal+unmarshal+size+pool+clone \

Gives --go-vtproto_out: unknown feature: "clone"
@delaneyj
Copy link
Author

delaneyj commented Jan 4, 2023

go install github.com/planetscale/vtprotobuf/cmd/protoc-gen-go-vtproto@0ae748fd2007a8ade11db4174599f4ba967b3f37 "fixes" it but I'm sure that's not the intention.

@nockty
Copy link
Contributor

nockty commented Sep 6, 2023

This sounds like it happened because the feature was not released at that time. It was part of version v0.4.0 which was released on January 27th.

clone should now work when installing with @latest, I've been using it successfully on my side. So, I'll just close this issue but feel free to let me know if you are still hitting something unexpected here.

@nockty nockty closed this as completed Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@delaneyj @nockty