Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable searching for people by phone number #378

Closed
trenton42 opened this issue Nov 9, 2017 · 5 comments
Closed

Enable searching for people by phone number #378

trenton42 opened this issue Nov 9, 2017 · 5 comments

Comments

@trenton42
Copy link

Detailed Description of the Problem/Question

It is possible to search for people by email using the emails endpoint: https://api.planningcenteronline.com/people/v2/emails. It does not appear that it is possible to search by phone number. The only listed endpoint for searching by phone number appears to be scoped to a person: https://api.planningcenteronline.com/people/v2/people/1/phone_numbers

Would it be possible to add an endpoint similar to the emails endpoint above? Something like https://api.planningcenteronline.com/people/v2/phone_numbers

Authentication method I'm using:

OAuth 2

@robertleib
Copy link

You can search for people via phone number using the people index endpoint docs:

https://api.planningcenteronline.com/people/v2/people?where[search_name_or_email]=NNNNNNN

(425) 555-1234
4255551234
1234
5551234
555-1234
51234

Those are all valid searches to find a person with the phone number (425) 555-1234. The name of that queryable scope is not clear that it includes phone numbers, so I am not surprised it wasn't discoverable. We can look at renaming it, and getting it documented.

Thanks!

--
Robbie

@seven1m
Copy link
Member

seven1m commented Dec 5, 2017

I'll work on getting that documented better...

@seven1m seven1m self-assigned this Dec 5, 2017
@trenton42
Copy link
Author

Hot dog, that's great! I didn't know I could do that. Thanks 👍

@seven1m seven1m closed this as completed Feb 4, 2019
@seven1m
Copy link
Member

seven1m commented Feb 4, 2019

I finally got this documented 😅

@trenton42
Copy link
Author

@seven1m 👏 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants