Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon background after 14.13.5 #53

Closed
lucaslacerdacl opened this issue Sep 18, 2023 · 16 comments · Fixed by #64
Closed

Icon background after 14.13.5 #53

lucaslacerdacl opened this issue Sep 18, 2023 · 16 comments · Fixed by #64
Labels
WIP Work in progress

Comments

@lucaslacerdacl
Copy link

Hello everyone! I'm using this library and recently I update Strapi to version 14.13.6.
After open my admin I notice that the order rank button was not the same.

  "dependencies": {
    "@retikolo/drag-drop-content-types": "^1.3.9",
    "@strapi/strapi": "4.13.6"
  }

The button looks like this:

Screenshot 2023-09-18 at 08 47 02

@lucaslacerdacl
Copy link
Author

anyone?

@derschiw
Copy link
Contributor

I will take a look, thanks for your report!

@derschiw
Copy link
Contributor

I couldn't reproduce this with strapi version 4.13.7, maybe update the minor version or can you provide more information?

@arastorhuiev
Copy link

same problem
"@retikolo/drag-drop-content-types": "^1.3.9",
"@strapi/plugin-i18n": "4.13.7",
"@strapi/plugin-users-permissions": "4.13.7",
"@strapi/provider-email-mailgun": "^4.14.0",
"@strapi/strapi": "4.13.7",
"better-sqlite3": "8.0.1",
"dotenv": "^16.3.1",
"react-copy-to-clipboard": "^5.1.0"

@arastorhuiev
Copy link

on 14.3.5 - ok, everything above - problem actually

@lucaslacerdacl
Copy link
Author

Hello guys! Well, you are correct @arastorhuiev , the problem rises after that release.

@derschiw
Copy link
Contributor

derschiw commented Oct 4, 2023

Is the button still working but has another color or isn't it working at all? As mentioned, couldn't reproduce that locally yet..

@lucaslacerdacl
Copy link
Author

The button is working just fine, I guess is only style problem.

@lucaslacerdacl lucaslacerdacl changed the title Icon background after 14.13.6 Icon background after 14.13.5 Oct 4, 2023
@arastorhuiev
Copy link

Is the button still working but has another color or isn't it working at all? As mentioned, couldn't reproduce that locally yet..

button is working correctly, only problem with styles

@lucaslacerdacl
Copy link
Author

Is there some documentation about contribution? I would like to try fix it.

@troc274
Copy link

troc274 commented Oct 7, 2023

I have the same issue. Anyone know how to fix it?
"dependencies": { "@retikolo/drag-drop-content-types": "^1.3.9", "@strapi/strapi": "4.13.7" }
Screenshot 2023-10-07 at 9 28 44 PM

@derschiw
Copy link
Contributor

derschiw commented Oct 9, 2023

Is there some documentation about contribution? I would like to try fix it.

It uses the Strapi Design System (https://design-system-git-main-strapijs.vercel.app/?path=/docs/design-system-components-iconbutton--docs). That's why I'm a little confused, how this could happen.

The code is here:

@derschiw
Copy link
Contributor

derschiw commented Oct 9, 2023

It seems that this is an issue with Strapi's Design System itself?

https://design-system-git-main-strapijs.vercel.app/?path=/story/design-system-components-v2-simplemenu--with-icons

@derschiw
Copy link
Contributor

I submitted an issue to the strapi design system. Consider upvoting to increase progress speed.

strapi/design-system#1418

@derschiw
Copy link
Contributor

Meanwhile I published a new version using another layout for the button. I will revert this as soon as Strapi fixes the other layout.

image

@derschiw
Copy link
Contributor

solved with #64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants