Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build broken by the new RELATIVE_INCLUDE variable #118

Closed
leio10 opened this issue Feb 8, 2021 · 2 comments
Closed

Build broken by the new RELATIVE_INCLUDE variable #118

leio10 opened this issue Feb 8, 2021 · 2 comments
Labels
stale Issue has not been active for 60 days

Comments

@leio10
Copy link

leio10 commented Feb 8, 2021

Hi! I'm working in the decidim project, and after one of the last commited changes the project documentation building process is failing with the following error:

Skipping plantuml block. Preprocessing of PlantUML include failed, because reading the referenced local file '%get_variable_value("RELATIVE_INCLUDE")/C4.puml' caused an error:
Error: ENOENT: no such file or directory, open '%get_variable_value("RELATIVE_INCLUDE")/C4.puml'

AFAIK, we are not defining a value for that variable, so it seems to be that the if condition is not working properly.

Should we modify anything on our project because of the last commit or it's a bug on this repo?

Thanks!

@adrianvlupu
Copy link
Member

Hi! Interesting project 👍

I suspect it's the version of plantuml that antora or asciidoc is using.
The %get_variable_value builtin preprocessor function doesn't seem to work.

I tested it locally with the latest jar file and with the online plantuml server and it seems to work fine, but with older versions it breaks.

Try to include !include https://raw.githubusercontent.com/plantuml-stdlib/C4-PlantUML/v2.0.1/C4.puml. This should work as before.

The master branch will most likely keep breaking with all the changes form PR requests, and it's only tested on the latest PlantUml version. We need a better way to keep track of what works with what version of PlantUML and keep things clearer.

@stale
Copy link

stale bot commented Apr 9, 2021

This issue has been automatically marked as stale because it has not had activity in the past 60 days. It will be closed in seven days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue has not been active for 60 days label Apr 9, 2021
@stale stale bot closed this as completed Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issue has not been active for 60 days
Projects
Status: Done
Development

No branches or pull requests

2 participants