Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate styling from symbols? #4

Closed
KyleKorndoerfer opened this issue Feb 25, 2019 · 3 comments
Closed

Separate styling from symbols? #4

KyleKorndoerfer opened this issue Feb 25, 2019 · 3 comments
Assignees
@RicardoNiepel

Comments

@KyleKorndoerfer
Copy link

The Common file includes several declarations that modify the theme/skinparams for things like arrows. This has the result that if I include an Azure symbol in my Sequence diagram all of the arrows are changed and I have to override the skinparams in each of my diagrams to return them back to their default. Could you place the the skinparam modifications into a separate puml file (CommonStyles) so that those of us that would like to include just the symbols can do so without changing the style(s) of our existing diagrams?

I can fork & submit a pull request if desired.
@RicardoNiepel
Copy link
Collaborator

Very good idea - I will do this

@RicardoNiepel RicardoNiepel self-assigned this Mar 28, 2019
@RicardoNiepel
Copy link
Collaborator

Done with 21829dc

@KyleKorndoerfer
Copy link
Author

Thank you! I look forward to it in the upstream PlantUML releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RicardoNiepel RicardoNiepel

Labels
None yet
Projects
All Projects
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RicardoNiepel @KyleKorndoerfer